1202290 - Loading image in fennec and panning around shows perma-blurry

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Nwxus 4 running sep 05 nightly. Load https://bug1109194.bmoattachments.org/attachment.cgi?id=8533829 and pan/rotate. The bottom part of the image seems to be rendered in low-res. It's fine on Aurora; probably a result of one of my recent viewport changes. It also seems to load zoomed in instead of zoomed to fit.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The loading zoomed in rather than zoomed to fit is "technically correct" since the synthetic document that is created to hold the image has a viewport of width=device-width;height=device-height. Old fennec CSS viewport code wasn't respecting this properly but the new CSS viewport code in MobileViewportManager does.

The low-res stuff is an issue with the composition bounds. I have a patch that fixes it (thankfully the patch involves deleting an old special-case code path rather than adding more stuff).

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

See commit message in the patch for the explanation. The old Fennec code that expanded the CSS viewport height was located at https://hg.mozilla.org/mozilla-central/rev/636fa61990f3#l4.238 and so that no longer happens.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a709157d5ef

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8657987 [details] [diff] [review]
Patch

Thanks for the explanation.

Happy to see this special case code go away.

So the widget does get resized, how does that work?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Not sure exactly what you're asking - but in the Java code when the toolbar is shown/hidden we send a message to the C++ code which resizes the widget accordingly, that code is at http://mxr.mozilla.org/mozilla-central/source/widget/android/nsWindow.cpp?rev=730d2acfbdb6#768

Comment 7

[Timothy Nikkel (:tnikkel)]

That answers my question thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e57b1f7edbe

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4e57b1f7edbe