[Settings] Convert messaging switches to use web components

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In preparation for moving to web components.

Comment 1

2 years ago
Created attachment 8657642 [details] [review]
[gaia] KevinGrandon:bug_1202301_settings_messaging_switches > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8657642 [details] [review]
[gaia] KevinGrandon:bug_1202301_settings_messaging_switches > mozilla-b2g:master

Hi Fred, please review if you have a chance. Thanks!
Attachment #8657642 - Flags: review?(gasolin)
(Assignee)

Updated

2 years ago
Assignee: nobody → kevingrandon

Comment 3

2 years ago
Comment on attachment 8657642 [details] [review]
[gaia] KevinGrandon:bug_1202301_settings_messaging_switches > mozilla-b2g:master

Code looks fine but got `TypeError: this._cbsInput is null` error.

It's very likely we need query proper gaia-switch in 
https://github.com/gasolin/gaia/blob/master/apps/settings/js/modules/messaging.js#L161
Attachment #8657642 - Flags: review?(gasolin)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8657642 [details] [review]
[gaia] KevinGrandon:bug_1202301_settings_messaging_switches > mozilla-b2g:master

Thanks for the review Fred, I found another spot that needed to be changed. Please take a look if you have time.
Attachment #8657642 - Flags: review?(gasolin)

Comment 5

2 years ago
Comment on attachment 8657642 [details] [review]
[gaia] KevinGrandon:bug_1202301_settings_messaging_switches > mozilla-b2g:master

lgtm, thanks!
Attachment #8657642 - Flags: review?(gasolin) → review+
(Assignee)

Comment 6

2 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/aad942e6960cdd6b2d09900b157b16f4ddb9423c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.