Closed Bug 1202318 Opened 4 years ago Closed 4 years ago

Intermittent layout/reftests/bidi/267459-1.html | image comparison (==), max difference: 169, number of differing pixels: 246

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox43 --- affected
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: nigelb, Assigned: jfkthame)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Disable resizing of textarea to work around unreliable Gtk3/asan rendering
2.42 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
No description provided.
It's another one of these. :(
Attachment #8706490 - Flags: review?(dholbert)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8706490 [details] [diff] [review]
Disable resizing of textarea to work around unreliable Gtk3/asan rendering

Review of attachment 8706490 [details] [diff] [review]:
-----------------------------------------------------------------

As in the other bugs, please update commit message to mention the test filename or just "in a mochitest", to avoid giving the impression you're making a platform-level change.

r=me with that.
Attachment #8706490 - Flags: review?(dholbert) → review+
(In reply to Daniel Holbert [:dholbert] from comment #14)
> As in the other bugs, please update commit message to mention the test
> filename or just "in a mochitest"

Sorry, "in a reftest" in this case.

Also, maybe remove "asan" from your commit message here.  I think (?) this is the only bug where you mentioned ASAN in the commit message, and coincidentally this bug has one non-ASAN report, on Linux x64 opt (and it does seem to be a valid report -- textarea has lines in its resizer in one screenshot, vs. dots in the other):
 https://treeherder.mozilla.org/logviewer.html#?repo=try&job_id=15249561

Bottom line, this bug is more frequent with ASAN, but it's not entirely ASAN-dependent.  (But it is GTK3-dependent, so it makes sense to mention that.)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dd5ad1c3b7ec54ae03365357c709ee7b8c0ce83
Bug 1202318 - Disable resizing of textarea in reftest bidi/267459-1 to work around unreliable Gtk3 rendering of the resize grabber. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/6dd5ad1c3b7e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.