Closed
Bug 1202407
Opened 9 years ago
Closed 9 years ago
Rename moz.b2g.version to langpack.channel
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
References
Details
Attachments
(1 file)
moz.b2g.version is only used by l10n.js to match apps with language resources. I'd like to suggest that we rename it to something which better matches its purpose. This will make it clearer that changing the value of the settings affects which langpacks are available in the Marketplace.
Reporter | ||
Comment 2•9 years ago
|
||
Another suggestion: moz.langpack.channel.
Comment 3•9 years ago
|
||
I like the channel. It will allow us to go for 2.5p for one partner, but another (who uses 2.5x branch) may opt for 2.5 langpack branch.
Flags: needinfo?(gandalf)
Reporter | ||
Updated•9 years ago
|
Summary: Rename moz.b2g.version to moz.langpack.version → Rename moz.b2g.version to langpack.channel
Comment 4•9 years ago
|
||
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8658584 [details] [review] [gaia] stasm:1202407-langpack.channel > mozilla-b2g:master Zibi, what do you think?
Attachment #8658584 -
Flags: feedback?(gandalf)
Comment 6•9 years ago
|
||
Comment on attachment 8658584 [details] [review] [gaia] stasm:1202407-langpack.channel > mozilla-b2g:master I like it!
Attachment #8658584 -
Flags: feedback?(gandalf) → feedback+
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8658584 [details] [review] [gaia] stasm:1202407-langpack.channel > mozilla-b2g:master Ricky, I'd like to make the name of the moz.b2g.version setting strictly reflect the fact that it's only related to langpacks. What do you think about this change? Fabrice, flagging you for feedback? too so that you're in the loop. Thanks!
Attachment #8658584 -
Flags: review?(rchien)
Attachment #8658584 -
Flags: feedback?(fabrice)
Updated•9 years ago
|
Attachment #8658584 -
Flags: review?(rchien) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8658584 [details] [review] [gaia] stasm:1202407-langpack.channel > mozilla-b2g:master Sure, that works for me.
Attachment #8658584 -
Flags: feedback?(fabrice) → feedback+
Reporter | ||
Comment 9•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/888b0a5d030580314b93ed6bafa88036dae93a72
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•