1202423 - [New-Homescreen] Provide a default app-order configuration

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

New homescreen needs to support a default app-order JSON file, similar to verticalhome.

Comment 1

[Chris Lord [:cwiiis]]

Going to tackle this before bug 1202422.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1202423-new-homescreen-default-app-order > mozilla-b2g:master

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8662439 [details] [review]
[gaia] Cwiiis:bug1202423-new-homescreen-default-app-order > mozilla-b2g:master

I think it's worth Kevin also having a look at this as I'm assuming he's more familiar with the setup of default app ordering in verticalhome, and what the intentions were.

This patch is quite basic, it ignores anything that doesn't have a manifestURL, and just restores order. It doesn't try to do anything clever with collections (which don't exist), or sections (which also don't exist currently in new-homescreen). It also restores columns settings, but it interprets <=3 as being 3-column and >3 as 4-column (no other settings are supported).

A marionette test is included.

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8662439 [details] [review]
[gaia] Cwiiis:bug1202423-new-homescreen-default-app-order > mozilla-b2g:master

Looks good to me, except the build part which I'm not familiar with, but as Kevin will review it too, Let's r+ it!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8662439 [details] [review]
[gaia] Cwiiis:bug1202423-new-homescreen-default-app-order > mozilla-b2g:master

Left comments, but seems fine. Thanks!

Comment 6

[Chris Lord [:cwiiis]]

Suggestions followed and added unit tests (confirmed with gmarty on IRC), merged: https://github.com/mozilla-b2g/gaia/commit/3e9de022ede11800170b6665606cb00c3fd92dc5