Closed
Bug 1202442
Opened 9 years ago
Closed 9 years ago
Update l20n.js to 3.0.6
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
References
Details
Attachments
(2 files)
No description provided.
|
||
Comment 1•9 years ago
|
||
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8658400 [details] [review] [gaia] stasm:1202442-l20n-3.0.6 > mozilla-b2g:master Waiting for a green build: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=14af7278765e5574a87ebed5e69f4c2b424cfdc9
Attachment #8658400 -
Flags: review?(gandalf)
|
||
Updated•9 years ago
|
Attachment #8658400 -
Flags: review?(gandalf) → review+
|
|
||
Comment 3•9 years ago
|
||
You may have to update FM after bug 1155099
|
|
Reporter | |
Comment 4•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/47459eead04385e22f967012b824f5abdddcfb7c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 5•9 years ago
|
||
This patches changes the patch for bug 1155099 (in FM Radio) and breaks it. No one in FM Radio reviewed the patch. Obviously it wasn't that trivial.
Flags: needinfo?(stas)
|
||
Comment 6•9 years ago
|
||
reverted in https://github.com/mozilla-b2g/gaia/commit/f55daf2e514dbdf29f173ae8627125818958db34
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 7•9 years ago
|
||
|
|
Reporter | |
Comment 8•9 years ago
|
||
Comment on attachment 8659174 [details] [review] [gaia] stasm:1202442-l20n-3.0.6-reland > mozilla-b2g:master Hi Hubert -- would you mind taking a quick look at this updated PR? mHzString is now properly set when the translation is retrieved. Thanks!
Flags: needinfo?(stas)
Attachment #8659174 -
Flags: review?(hub)
|
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8659174 [details] [review] [gaia] stasm:1202442-l20n-3.0.6-reland > mozilla-b2g:master ship it !
Attachment #8659174 -
Flags: review?(hub) → review+
|
|
Reporter | |
Comment 10•9 years ago
|
||
Thanks! https://github.com/mozilla-b2g/gaia/commit/bfc77a7b8854484317a781581c87fc26da92809b
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•