Closed Bug 1202478 Opened 9 years ago Closed 9 years ago

Run WebExtension callbacks asynchronously

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: billm, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Even though the API is asynchronous, callbacks are run synchronously right now. That seems to cause problems for Adblock Plus. This patch just runs most callbacks asynchronously. The exception is webRequest, since we need to know the blocking decision right away. Eventually that will need to be fixed before implementing out-of-process WebExtensions.
Attachment #8657910 - Flags: review?(gkrizsanits)
Blocks: webext-oop
Attachment #8657910 - Flags: review?(gkrizsanits) → review+
Backed out the whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e83a8b6b8e since it was intertangled and I wasn't entirely sure which part caused Mulet mochitest-5 to become permaorange with https://treeherder.mozilla.org/logviewer.html#?job_id=14545777&repo=mozilla-inbound
https://hg.mozilla.org/mozilla-central/rev/3cdf59ce6259
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: