1202483 - Support ImageData for browser.browserAction.setIcon

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

See https://developer.chrome.com/extensions/browserAction#method-setIcon.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

The tricky part here is that the ImageData must be rendered into a canvas that's same-origin with the ImageData. To do that, we need to create a windowless docshell with the extension's principal and create a <canvas> inside of it.

One problem here is that the GlobalManager code assumes that any docshell created with extension principals must be a tab that's showing extension content. That's not the case here, so I added a call to GlobalManager.injectInDocShell with a null context. That causes the icon docshell to be ignored.

I also moved some common test code into head.js.

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8657938 [details] [diff] [review]
patch

Review of attachment 8657938 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is correct, but please consider my comment below...

::: browser/components/extensions/ext-browserAction.js
@@ +273,5 @@
> +function convertImageDataToPNG(extension, imageData)
> +{
> +  let webNav = imageRendererMap.get(extension);
> +  if (!webNav) {
> +    webNav = Services.appShell.createWindowlessBrowser(false);

I don't quite get why do we have to create a docshell for this. Shouldn't the caller context of this API always have a docshell/document with this principal that we can use here to create the canvas?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #2)
> I don't quite get why do we have to create a docshell for this. Shouldn't
> the caller context of this API always have a docshell/document with this
> principal that we can use here to create the canvas?

Yes, there will be a document for the background page, but I don't want to create a canvas element there since it would be visible to the extension.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b6e99e620e

Comment 5

[Phil Ringnalda (:philor)]

Backed out the whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e83a8b6b8e since it was intertangled and I wasn't entirely sure which part caused Mulet mochitest-5 to become permaorange with https://treeherder.mozilla.org/logviewer.html#?job_id=14545777&repo=mozilla-inbound

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fcec26b5327

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9fcec26b5327