1202486 - Small fixes for message ports

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

The message port code is a bit broken. The parameter handling in runtime.connect doesn't handle the case where the extensionId parameter is not passed in (which is the typical case).

Also, the disconnect code is kind of busted. Right now we ignore disconnect messages unless the extension is listening for them. However, we need to listen for these disconnect messages so that we know not to send any messages to the other side. This patch fixes the problem.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37e6ac7beb42

Comment 2

[Phil Ringnalda (:philor)]

Backed out the whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e83a8b6b8e since it was intertangled and I wasn't entirely sure which part caused Mulet mochitest-5 to become permaorange with https://treeherder.mozilla.org/logviewer.html#?job_id=14545777&repo=mozilla-inbound

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cbbb1b393bd9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbbb1b393bd9