Closed Bug 1202506 Opened 4 years ago Closed 4 years ago

Reload/stop/go start border is missing on OSX

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ntim, Unassigned)

References

Details

border-image-slice: 1; is missing from https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#1899 , which is causing the start border not to show.

A side-note: It may be worth moving these urlbar button related rules into a shared file.
Summary: Reload/stop/go start border is missing → Reload/stop/go start border is missing on OSX
Just adding that isn't enough, though, because it shows a border to the right of the reload/stop/go button as well, as noted on bug 1185960:

(In reply to Tim Nguyen [:ntim] from comment #26)
> (In reply to Pulsebot from comment #25)
> > https://hg.mozilla.org/integration/fx-team/rev/ec99f1dfd668
> 
> In my testing using developer tools, I think the patch also needs
> border-style: none;/border-width: 0; otherwise an end border will also
> appear.

That and the spacing between the buttons just looks wrong on OS X (attachment 8657888 [details]). Not sure what's up with that.
This was taken care of in https://hg.mozilla.org/integration/fx-team/rev/ec99f1dfd668
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.