"Include this server when getting new mail" is greyed out when "Inbox for this server" is selected

RESOLVED FIXED in Thunderbird 45.0

Status

MailNews Core
Account Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Rob, Assigned: aceman)

Tracking

Thunderbird 45.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

10.60 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826023504

Steps to reproduce:

Tools -> Account Settings -> Server Settings -> Advanced


Actual results:

When "Inbox for this server's account" is selected the check box for "Include this server when getting new mail" is greyed out.

Platform Win 7Pro 32 bit, Thunderbird 38.2.0 (upgraded directly from 3.04)


Expected results:

Check box for "Include this server when getting new mail" should be active.

Workaround is to select "Inbox for different account", set the check box as desired, and then reselect "Inbox for this server's account"
(Assignee)

Comment 1

2 years ago
Maybe that option has no sense when the account's own inbox is used?
(Reporter)

Comment 2

2 years ago
(In reply to :aceman from comment #1)
> Maybe that option has no sense when the account's own inbox is used?

The option makes sense, and used to work in v3.0 (I upgraded straight from v3.0 to v38).  I am using POP, and without the box checked I don't automatically get new emails.
(Assignee)

Comment 3

2 years ago
Did you check "check for new messages every X minutes" or "automatically download new messages" in the accounts "server settings" (but not Advanced)?
(Reporter)

Comment 4

2 years ago
Yes. Please read my original description where I got it to work with the workaround.  Are you able to reproduce the bug, that is that the check box is greyed out?
(Assignee)

Comment 5

2 years ago
Yes, I see the workaround. I just ask what is the effect when you tick that option. What does it do differently than the 2 options I mentioned. You just say what you want to tick. I ask why you want to tick it, what feature it represents. Is mail not downloaded when clicking "get all messages" on toolbar to that account if that option is not ticked?

Between v3 and v38 there were several changes to that dialog (also by me) and the checkbox is intentionally disabled because we came to the conclusion the option has no effect if the account stores mail in its own inbox (i.e. is NOT deferred to another one). So I try to understand why you think that is not true, what special feature it implements that we forgot about.
(Reporter)

Comment 6

2 years ago
Hi - I see what you are saying.  There was some reason why my installation didn't retrieve new messages automatically after I upgraded even though I had the settings as described above.  When I ticked the box using the workaround then it started working for me, hence raising the bug. 

I have just moved to a new Win 8.1 computer yesterday with a new Thunderbird 38 install, copied my profile across and then unticked the check box today and it still automatically retrieved a test message for me (that is it worked as you expected).

I guess that this was a quirk with the upgraded install on my old computer, and is not actually a bug.   

Thanks for your patience.

Robert
(Assignee)

Comment 7

2 years ago
Thanks for the findings. In that case maybe the text for the checkbox is misleading. If the Inbox is on the same account but the option is unticked and disabled, the user may think mail will not be retrieved when clicking "get new mail".

1. We could either hide the option when the same account is selected. But I don't think we do hide/unhide checkboxes in TB UI.

2. Or we could improve the label on it, from "Include this server when getting new mail" to something else, but I do not know what. We could also indent the option to make it appear as part of the "other account option".
Assignee: nobody → acelists
Status: UNCONFIRMED → ASSIGNED
Component: Account Manager → Account Manager
Ever confirmed: true
Flags: needinfo?(richard.marti)
OS: Unspecified → All
Product: Thunderbird → MailNews Core
Hardware: Unspecified → All
(Reporter)

Comment 8

2 years ago
Perhaps "Include that account's server when getting new mail" as well as indenting it.
I think it's the best indenting this option. This makes it clear it's only used when the "other account" option is enabled.
Flags: needinfo?(richard.marti)
(Assignee)

Comment 10

2 years ago
Created attachment 8663351 [details] [diff] [review]
patch

I've indented the option and also changed some of the wording to hopefully make the radio options more clear.
Attachment #8663351 - Flags: ui-review?(richard.marti)
Attachment #8663351 - Flags: review?(iann_bugzilla)
Comment on attachment 8663351 [details] [diff] [review]
patch

LGTM. Also the string changes are looking correct. Ian, as a native English speaker, will naturally be a better reference.
Attachment #8663351 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Comment 12

2 years ago
Created attachment 8663395 [details] [diff] [review]
patch v1.1

Thanks. This version adds one missing SM string.
Attachment #8663351 - Attachment is obsolete: true
Attachment #8663351 - Flags: review?(iann_bugzilla)
Attachment #8663395 - Flags: review?(mkmelin+mozilla)
Attachment #8663395 - Flags: review?(iann_bugzilla)

Comment 13

2 years ago
Comment on attachment 8663395 [details] [diff] [review]
patch v1.1

Review of attachment 8663395 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8663395 - Flags: review?(mkmelin+mozilla) → review+

Comment 14

2 years ago
Comment on attachment 8663395 [details] [diff] [review]
patch v1.1

>+++ b/mail/locales/en-US/chrome/messenger/am-server-advanced.dtd
>+<!ENTITY pop3DeferringDesc.label "When downloading mail from this account's server, use the following folder to store new messages:" >
>+<!ENTITY accountInbox.label "Inbox for this account">
>+<!ENTITY accountInbox.accesskey "S">
The accesskey should match the case of the letter is matching (i.e. "s" rather than "S"), saying that perhaps should be using "n" or "b" as they are earlier in the label.
> <!ENTITY deferToServer.label "Inbox for different account">
> <!ENTITY deferToServer.accesskey "D">
Should be "d"

>+++ b/suite/locales/en-US/chrome/mailnews/pref/am-server-advanced.dtd
>+<!ENTITY pop3DeferringDesc.label "When downloading mail from this account's server, use the following folder to store new messages:" >
>+<!ENTITY accountInbox.label "Inbox for this account">
>+<!ENTITY accountInbox.accesskey "S">
Comment as for mail/
> <!ENTITY deferToServer.label "Inbox for different account">
> <!ENTITY deferToServer.accesskey "D">
Comment as for mail/

r=me with those comments addressed.
Attachment #8663395 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 15

2 years ago
Created attachment 8690222 [details] [diff] [review]
patch v1.2

Well, I'm only moving those accesskeys, but I can fix them if you wish so.
Attachment #8663395 - Attachment is obsolete: true
Attachment #8690222 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 16

2 years ago
Comment on attachment 8690222 [details] [diff] [review]
patch v1.2

a=Ratty for SeaMonkey CLOSED TREE
(Assignee)

Comment 17

2 years ago
https://hg.mozilla.org/comm-central/rev/c2b70a33a5fa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.