1202528 - Every time visibiltiychange from hidden to show, a network activity icon is inserted

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Ting-Yu Chou [:ting] (away)]

STR:
1. Press power button on/off several times (my phone has SIM and WiFi enabled)
2. Use WebIDE for system app, in the inspector search #statusbar-network-activity, there'll be many.

Root cause:
In network_activity.js, when document is shown, _handle_visibilitychange() calls BaseIcon.start(), which will render() and insert the view.

Comment 1

[Ting-Yu Chou [:ting] (away)]

This can be fixed by either a) add a customized render() like TimeIcon [1] to render only once, or b) only insert the view if the element is null in BaseIcon.render(). And I prefer b.

How do you think?

[1] http://lxr.mozilla.org/gaia/source/apps/system/js/time_icon.js#26

Comment 2

[Alberto Pastor [:albertopq]]

B is actually the way BaseUI (which BaseIcon inherits from) works https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/base_ui.js#L24.

So yes, it should only inster elements once. Do you want me to take this one?

Comment 3

[Ting-Yu Chou [:ting] (away)]

I'm fine for both taking or not taking, if you do not take, I'll fix it next week.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1202528-base-icon-once > mozilla-b2g:master

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8660731 [details] [review]
[gaia] albertopq:1202528-base-icon-once > mozilla-b2g:master

Can we remove the special renderer in TimeIcon now? (fine if you want to do it in a follow up).

Anyway, good catch :)

Comment 6

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/d130529c626695570c7b5017d9b43955115d68a0