120253 - Fix leaks and occasional crashes of the combination generated content/content model view

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Jan Varga [:janv]]

I noticed when I closed a window with generated content that content view's dtor
was not called. I works fine elsewhere, e.g. Preferences.

And I also crashed later.

I also noticed one thing. nsXULDocument::CheckTemplateBuilder()
doesn't bail out for rdfliner, since rdfliner doesn't set "database" attribute.

Comment 1

[Jan Varga [:janv]]

I originaly changed GetDatabase() check to GetTemplateBuilderFor() as part of
the syntax change, but then I realized that it might cause problems.

Comment 2

[Chris Waterson]

The rdfliner calls SetTemplateBuilderFor at (around) nsXULDocument.cpp:6401 --
shouldn't that suffice?

Comment 3

[Jan Varga [:janv]]

yes, you are right, but ...

If I don't check for already created and appended <outlinerchildren> in
nsXULDocument::CheckTemplateBuilder()
I get 2 <outlinerchildren>s and 2 outliner body frames of course, it looks
really weird.

So I think SetTemplateBuilderFor() is called, but database attribute is present 
later

It doesn't create 2 tags when I replace GetDatabase() check with
GetTemplateBuilderFor() in nsXULDocument::CheckTemplateBuilder()

Comment 4

[Jan Varga [:janv]]

It seems that this is not an issue anymore. I don't see it.
Probably waterson's fix for 86755.
Marking WFM.