1202534 - [Browser] Icon selected for pinning site badge when multiple icon link relations are present in current page

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Alison Shiue]

Attachment: Icon_on_Aries.png

STR:
1. Enable Pin the Web in Settings
2. Go to http://alison-shiue.github.io/icon_type/multiple_icons.html, this page provides 4 different icons.
3. Tap site icon on URL bar
4. Check the site icon shows on pin site badge

Expected result: 
The next largest site icon nearest to the required size should be used, so Rabbit icon shows (65x65)

Actual result: 
Bear icon shows (90x90)

** Besides, do we have any rule to choose site icon on URL bar? The site icon selected on flame and aries is defferent. flame shows rabbit(65x65), and aries shows dog(70x70).


Build info:
[aries]
Build ID               20150907110522
Gaia Revision          891798f1e345bc2b69e71de42bd524a90b1745c4
Gaia Date              2015-09-07 02:49:56
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5fe9ed3edd6811a662d40d05e37b0d66e9520d82
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150907.102632
Firmware Date          Mon Sep  7 10:26:39 UTC 2015
Bootloader             s1

[flame]
Build ID               20150907150218
Gaia Revision          891798f1e345bc2b69e71de42bd524a90b1745c4
Gaia Date              2015-09-07 02:49:56
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5fe9ed3edd6811a662d40d05e37b0d66e9520d82
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150907.182946
Firmware Date          Mon Sep  7 18:29:58 EDT 2015
Bootloader             L1TC000118D0

Comment 1

[Alison Shiue]

Attachment: Icon_on_Flame.png

Comment 2

[Alison Shiue]

Update the test url: http://alison-shiue.github.io/without_manifest/multiple_icons.html

Comment 3

[Alison Shiue]

Besides, site icon shows on pin page dialog also choose different icons, flame shows cat(40x40), and aries shows rabbit(65x65).

Do we have any rule for picking site icon for URL bar, pin site badge, and pin page dialog?

Comment 4

[Alberto Pastor [:albertopq]]

Hi Alison. It tries to get the closest icon for the requested size (32x32  for the site icon, if I'm not wrong), but multiplied by the DPPX (2.25 on Aries), so I think getting the 40x40 on the Flame, and 65x65 on the Aries is correct. Does that answer the question?

Comment 5

[Alison Shiue]

Attachment: icon_choose.png

Hi Alberto,

Thanks for the reply!

According to Spec:
  (1) requested size for site icon on URL bar is 32x32 (https://goo.gl/eVSX24) 
  (2) requested size for site icon on pin site badge is 64x64 (https://goo.gl/MbxQtt)
  (3) requested size for site icon on pin page dialog  ...32x32(?)

And here are test icons:
  Bird size: 33x33
  Cat size: 40x40
  Rabbit size: 65x65
  Fish size: 68x68
  Dog size: 70x70
  Bear size: 90x90
  Elephant size: 150x150

So...

For Flame: DPPX (1.5) 
  pin site icon on URL bar (48x48): should choose Cat(40x40) 
  pin site icon on pin site badge (96x96): should choose Bear(90x90) 
  pin site icon on pin page dialog (48x48): should choose Cat(40x40) 
 
For Aries: DPPX (2.25)
  pin site icon on URL bar (72x72): should choose Dog(70x70)  
  pin site icon on pin site badge (144x144): should choose Elephant(150x150) 
  pin site icon on pin page dialog (72x72): should choose Dog(70x70)

Are above the expected results?

Comment 6

[Alberto Pastor [:albertopq]]

I guess that's correct. The site badge (the one at the bottom) in the Pin Page dialog is requested at 70x70 as it was blurry when scaling.

Comment 7

[Alison Shiue]

(In reply to Alberto Pastor [:albertopq] from comment #6)
> I guess that's correct. The site badge (the one at the bottom) in the Pin
> Page dialog is requested at 70x70 as it was blurry when scaling.

Sorry Alberto, I don't understand very well.
Does the requested size (70x70) you mentioned not be multiplied by the DDPX? 
So the site badge in the Pin Page dialog: the closest icon for Flame should choose Bear(70x1.5=105) , and for Aries should choose Elephant(70x2.25=157.5)?

Observe these two devices, 
---------------------------------------------------------------
Device   Site icon on                   Expected       Actual
---------------------------------------------------------------
Aries    URL bar                          Dog           Dog
         Site badge                     Elephant      Elephant
         Site badge in pin page         Elephant       Rabbit
---------------------------------------------------------------
Flame    URL bar                          Cat          Rabbit
         Site badge                       Bear          Bear
         Site badge in pin page           Bear          Cat

Comment 8

[Alberto Pastor [:albertopq]]

Hi Alison.

Sorry, I forgot bug 1205212 is not merged yet (that will make the badge in the pin page 72x72). In the current implementation, the Site badge in pin page gets requested with the default size, which is 32.

At the other hand, the URL bar icon gets requested at 34, as it adds some treatment to the image (shadows) and needs 2px padding.

So:

URL bar -> 34                      
Site badge -> 64                  
Site badge in pin page -> 32 (will become 72 after bug 1205212)


Hopefully that makes everything make sense.

Comment 9

[Alison Shiue]

OK, I get it, thank you Alberto!

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Ben, what do you think? Based on comment 8 I'm thinking this is a WFM.

Comment 11

[Ben Francis [:benfrancis]]

This should be fixed now, please reopen if there are still issues.