1202561 - Remove no-longer-used constants from jsversion.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

js/src/jsversion.h has some constants that are no longer used anywhere.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove no-longer-used constants from jsversion.h

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8658022 [details] [diff] [review]
Remove no-longer-used constants from jsversion.h

Review of attachment 8658022 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, ok. I imagine that by now, all embedders have been blasted off the sheer rock wall of supporting both ancient JSAPI versions and modern ones in a single codebase.

Comment 3

[Nicholas Nethercote [inactive]]

I was working under the assumption that jsversion.h should disappear one day (1JS and all that, and see bug 909570 comment 0), except maybe for the "only in Nightly" section.

If this does make embedders' lives harder I'm happy to abandon it.

Comment 4

[Jason Orendorff [:jorendorff]]

> I was working under the assumption that jsversion.h should disappear one day

Yes, but a patch like this is not a big contribution to that effort, which is mostly about properly warning about deleting legacy features, measuring the declining usage, and updating old code.

> If this does make embedders' lives harder I'm happy to abandon it.

Either way is fine with me.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Mark no-longer-used constants in jsversion.h

One last compromise: use comments to indicate which ones are no longer used.

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 8662670 [details] [diff] [review]
Mark no-longer-used constants in jsversion.h

Review of attachment 8662670 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsversion.h
@@ +33,1 @@
>  #define JS_HAS_MAKE_SYSTEM_OBJECT       1

This one is not only no longer used -- it's wrong. We don't have any such API anymore. So please do delete this one :-\

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/261f7065e60f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/261f7065e60f