Closed
Bug 1202561
Opened 9 years ago
Closed 9 years ago
Remove no-longer-used constants from jsversion.h
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file, 1 obsolete file)
2.64 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
js/src/jsversion.h has some constants that are no longer used anywhere.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8658022 -
Flags: review?(jorendorff)
Comment 2•9 years ago
|
||
Comment on attachment 8658022 [details] [diff] [review] Remove no-longer-used constants from jsversion.h Review of attachment 8658022 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, ok. I imagine that by now, all embedders have been blasted off the sheer rock wall of supporting both ancient JSAPI versions and modern ones in a single codebase.
Attachment #8658022 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 3•9 years ago
|
||
I was working under the assumption that jsversion.h should disappear one day (1JS and all that, and see bug 909570 comment 0), except maybe for the "only in Nightly" section. If this does make embedders' lives harder I'm happy to abandon it.
Flags: needinfo?(jorendorff)
Comment 4•9 years ago
|
||
> I was working under the assumption that jsversion.h should disappear one day Yes, but a patch like this is not a big contribution to that effort, which is mostly about properly warning about deleting legacy features, measuring the declining usage, and updating old code. > If this does make embedders' lives harder I'm happy to abandon it. Either way is fine with me.
Flags: needinfo?(jorendorff)
Assignee | ||
Comment 5•9 years ago
|
||
One last compromise: use comments to indicate which ones are no longer used.
Attachment #8662670 -
Flags: review?(jorendorff)
Assignee | ||
Updated•9 years ago
|
Attachment #8658022 -
Attachment is obsolete: true
Comment 6•9 years ago
|
||
Comment on attachment 8662670 [details] [diff] [review] Mark no-longer-used constants in jsversion.h Review of attachment 8662670 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsversion.h @@ +33,1 @@ > #define JS_HAS_MAKE_SYSTEM_OBJECT 1 This one is not only no longer used -- it's wrong. We don't have any such API anymore. So please do delete this one :-\
Attachment #8662670 -
Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/261f7065e60f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•