1202663 - Convert screen capture commands in listener to use new dispatching technique

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Comment 1

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f97708d91b0e

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1202663: Use dispatcher for screen capture command in listener

Bug 1202663: Use dispatcher for screen capture command in listener

r=dburns

Comment 3

[David Burns :automatedtester]

Comment on attachment 8658184 [details]
MozReview Request: Bug 1202663: Use dispatcher for screen capture command in listener

https://reviewboard.mozilla.org/r/18499/#review16555

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/820865a790e4

Comment 5

[Andreas Tolfsen ❲:ato❳]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/dfeeb0a2d403 for test failures like https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=820865a790e4.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreas, this problem is currently our #1 hang in the functional firefox-ui-tests. Sadly a fix was not part of the yesterdays 1.0.0 release via bug 1209698.

Would you mind to tell us if this is something you have the time to get fixed anytime soon? I would appreciate it. Thanks.

Comment 7

[Andreas Tolfsen ❲:ato❳]

I might get around to this tomorrow or early next week.

Comment 8

[Andreas Tolfsen ❲:ato❳]

new try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5949d6d88b2

Comment 9

[Andreas Tolfsen ❲:ato❳]

Scratch that, doing a new try run with both debug and optimised builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f307d9d85334

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/443dc9a9c21c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for Wr bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=15195232&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab2e3d60643

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c78b98786927

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34285c9ddb94

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec49c03a0597

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c78b98786927
https://hg.mozilla.org/mozilla-central/rev/34285c9ddb94
https://hg.mozilla.org/mozilla-central/rev/ec49c03a0597

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreas, are you going to release new versions of client and driver or do we need something else still?

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreas, I wonder if we also can get this backported at least down to beta.

Comment 18

[Andreas Tolfsen ❲:ato❳]

dburns has a better overview than me if we can do that.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c615a2e6b269
https://hg.mozilla.org/releases/mozilla-aurora/rev/4149b264250c
https://hg.mozilla.org/releases/mozilla-aurora/rev/cfaf54890d17

Comment 20

[Carsten Book [:Tomcat]]

for beta this failed to uplift :

grafting 309559:c615a2e6b269 "Bug 1202663 -  Use dispatcher for screen capture command in listener. r=AutomatedTester, r=jgriffin, a=test-only"
merging testing/marionette/driver.js
warning: conflicts during merge.
merging testing/marionette/driver.js incomplete! (edit conflicts, then use 'hg resolve --mark')
merging testing/marionette/listener.js
warning: conflicts during merge.
merging testing/marionette/listener.js incomplete! (edit conflicts, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out from Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/ffa9e4184d55 for Wr bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=1351573&repo=mozilla-aurora

Comment 22

[Carsten Book [:Tomcat]]

clearing checkin-needed to remove it from our checkin-needed query till we have a solution for this bug. Please add this again when this bug/patch is ready for checkin, thanks!

Comment 23

[Andreas Tolfsen ❲:ato❳]

I’m not convinced we should put in the extra work to backport this for uplift to Aurora, but if anyone wants to they’re more than welcome to do it.

Essentially you’d have to figure out what dependencies (other patches) are required to be uplifted to Aurora before this patch can be cleanly applied.