Closed Bug 1202663 Opened 4 years ago Closed 4 years ago
Convert screen capture commands in listener to use new dispatching technique
40 bytes, text/x-review-board-request
No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Bug 1202663: Use dispatcher for screen capture command in listener r=dburns
Attachment #8658184 - Flags: review?(dburns)
Comment on attachment 8658184 [details] MozReview Request: Bug 1202663: Use dispatcher for screen capture command in listener https://reviewboard.mozilla.org/r/18499/#review16555
Attachment #8658184 - Flags: review?(dburns) → review+
Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/dfeeb0a2d403 for test failures like https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=820865a790e4.
Andreas, this problem is currently our #1 hang in the functional firefox-ui-tests. Sadly a fix was not part of the yesterdays 1.0.0 release via bug 1209698. Would you mind to tell us if this is something you have the time to get fixed anytime soon? I would appreciate it. Thanks.
I might get around to this tomorrow or early next week.
Scratch that, doing a new try run with both debug and optimised builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f307d9d85334
Backed out for Wr bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=15195232&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab2e3d60643
Andreas, are you going to release new versions of client and driver or do we need something else still?
Andreas, I wonder if we also can get this backported at least down to beta.
dburns has a better overview than me if we can do that.
Flags: needinfo?(ato) → needinfo?(dburns)
Whiteboard: [qa-automation-blocked] → [checkin-needed-aurora][checkin-needed-beta][qa-automation-blocked]
https://hg.mozilla.org/releases/mozilla-aurora/rev/c615a2e6b269 https://hg.mozilla.org/releases/mozilla-aurora/rev/4149b264250c https://hg.mozilla.org/releases/mozilla-aurora/rev/cfaf54890d17
Whiteboard: [checkin-needed-aurora][checkin-needed-beta][qa-automation-blocked] → [checkin-needed-beta][qa-automation-blocked]
for beta this failed to uplift : grafting 309559:c615a2e6b269 "Bug 1202663 - Use dispatcher for screen capture command in listener. r=AutomatedTester, r=jgriffin, a=test-only" merging testing/marionette/driver.js warning: conflicts during merge. merging testing/marionette/driver.js incomplete! (edit conflicts, then use 'hg resolve --mark') merging testing/marionette/listener.js warning: conflicts during merge. merging testing/marionette/listener.js incomplete! (edit conflicts, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use hg resolve and hg graft --continue)
Backed out from Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/ffa9e4184d55 for Wr bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=1351573&repo=mozilla-aurora
clearing checkin-needed to remove it from our checkin-needed query till we have a solution for this bug. Please add this again when this bug/patch is ready for checkin, thanks!
Whiteboard: [checkin-needed-beta][qa-automation-blocked] → [qa-automation-blocked]
I’m not convinced we should put in the extra work to backport this for uplift to Aurora, but if anyone wants to they’re more than welcome to do it. Essentially you’d have to figure out what dependencies (other patches) are required to be uplifted to Aurora before this patch can be cleanly applied.
You need to log in before you can comment on or make changes to this bug.