Closed
Bug 1202667
Opened 7 years ago
Closed 7 years ago
micro-optimize refcounting in TaskQueue
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(2 files)
1.01 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
1.00 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
This is micro-optimizing, but it feels worthwhile, because the refcounting here on runnables is thread-safe, and avoiding atomic operations seems like a good idea.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
We're already holding a reference to the Runner prior to dispatching it to the thread pool; we can pass that reference in rather than requiring the thread pool to take a new reference to it.
Attachment #8658174 -
Flags: review?(continuation)
![]() |
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8658175 -
Flags: review?(continuation)
Updated•7 years ago
|
Attachment #8658174 -
Flags: review?(continuation) → review+
Updated•7 years ago
|
Attachment #8658175 -
Flags: review?(continuation) → review+
Comment 3•7 years ago
|
||
I CC'ed Olli because he likes refcounting microoptimizations. ;)
https://hg.mozilla.org/integration/mozilla-inbound/rev/348b09b8d643 https://hg.mozilla.org/integration/mozilla-inbound/rev/fe19d71aae51
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/348b09b8d643 https://hg.mozilla.org/mozilla-central/rev/fe19d71aae51
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•