Closed Bug 1202667 Opened 5 years ago Closed 5 years ago

micro-optimize refcounting in TaskQueue

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

make TaskQueue dispatching slightly more efficient
1.01 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
make TaskQueue task running slightly more efficient
1.00 KB, patch
mccr8
: review+
Details | Diff | Splinter Review 
This is micro-optimizing, but it feels worthwhile, because the refcounting here
on runnables is thread-safe, and avoiding atomic operations seems like a good
idea.
We're already holding a reference to the Runner prior to dispatching it
to the thread pool; we can pass that reference in rather than requiring
the thread pool to take a new reference to it.
Attachment #8658174 - Flags: review?(continuation)
Attachment #8658174 - Flags: review?(continuation) → review+
Attachment #8658175 - Flags: review?(continuation) → review+
I CC'ed Olli because he likes refcounting microoptimizations. ;)
https://hg.mozilla.org/mozilla-central/rev/348b09b8d643
https://hg.mozilla.org/mozilla-central/rev/fe19d71aae51
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.