micro-optimize refcounting in TaskQueue

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

This is micro-optimizing, but it feels worthwhile, because the refcounting here
on runnables is thread-safe, and avoiding atomic operations seems like a good
idea.
We're already holding a reference to the Runner prior to dispatching it
to the thread pool; we can pass that reference in rather than requiring
the thread pool to take a new reference to it.
Attachment #8658174 - Flags: review?(continuation)
Attachment #8658174 - Flags: review?(continuation) → review+
Attachment #8658175 - Flags: review?(continuation) → review+
I CC'ed Olli because he likes refcounting microoptimizations. ;)
https://hg.mozilla.org/mozilla-central/rev/348b09b8d643
https://hg.mozilla.org/mozilla-central/rev/fe19d71aae51
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.