1202670 - Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

This is pretty finicky, but particularly with bug 1202526 in place this nsCC method ends up doing a lot of poking around into the CC graph. I think it is better to just move it all into a method, and then hide some of the CCGraph methods as allowed.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14e972868475

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8665622 [details] [diff] [review]
Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

This isn't quite right yet.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

The only difference in this version is that it makes FindNodeEntry private.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8665640 [details] [diff] [review]
Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

>+  PtrToNodeEntry* FindNodeEntry(void* aPtr) {
{ to its own line ;)

Comment 8

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #7)
> { to its own line ;)

Fixed.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abcd5e8f274d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abcd5e8f274d