Closed Bug 1202670 Opened 7 years ago Closed 7 years ago

Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

This is pretty finicky, but particularly with bug 1202526 in place this nsCC method ends up doing a lot of poking around into the CC graph. I think it is better to just move it all into a method, and then hide some of the CCGraph methods as allowed.
Assignee: nobody → continuation
Attachment #8660061 - Attachment is obsolete: true
Attachment #8660061 - Flags: review?(continuation)
Attachment #8660062 - Attachment is obsolete: true
Attachment #8660062 - Attachment is obsolete: false
Attachment #8660062 - Attachment is obsolete: true
Attachment #8660083 - Attachment is obsolete: true
Comment on attachment 8665622 [details] [diff] [review]
Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

This isn't quite right yet.
Attachment #8665622 - Flags: review?(bugs)
The only difference in this version is that it makes FindNodeEntry private.
Attachment #8665640 - Flags: review?(bugs)
Comment on attachment 8665640 [details] [diff] [review]
Move most of nsCycleCollector::RemoveObjectFromGraph into CCGraph.

>+  PtrToNodeEntry* FindNodeEntry(void* aPtr) {
{ to its own line ;)
Attachment #8665640 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #7)
> { to its own line ;)

Fixed.
https://hg.mozilla.org/mozilla-central/rev/abcd5e8f274d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.