Closed Bug 1202707 Opened 4 years ago Closed 4 years ago

Remove emulator commands from simpletest harness

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

By not exposing the emulator command functions on the simpletest harness that we inject as globals when the user executes script, we can avoid a bit of tight coupling between simpletest.js and the chrome- and content space.

Instead we can bind the functions and add them directly in the command implementation.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Bug 1202707: Remove emulator commands from simpletest harness

We attach the emulator commands outside of the simpletest harness.
Removing this makes testing/marionette/simpletest.js less dependent
on Marionette.

r=dburns
Attachment #8658245 - Flags: review?(dburns)
Comment on attachment 8658245 [details]
MozReview Request: Bug 1202707: Remove emulator commands from simpletest harness

https://reviewboard.mozilla.org/r/18507/#review16591

::: testing/marionette/simpletest.js:15
(Diff revision 1)
> -                           heartbeatCallback, testName) {
> +    heartbeatCallback, testName) {

please put the white space back
Attachment #8658245 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/bebf1050fa4d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.