1202712 - Replace unknown favicon outline box with globe icon

Status: RESOLVED DUPLICATE of bug 1074937

(Firefox :: General, defect)

Description

[Edwin Wong [:edwong]]

The current default favicon for nonexistent favicons is a dash line outline of a box. This looks weird and is different than Android.

1. setup sync on profile A, add bookmarks
2. setup sync on profile B, sync

actual: you see a favicons with 'dash line outline of a box'

expected: you should see something pretty, like a globe, which is more consistent with Mobile Fx browsers.

Comment 1

[Edwin Wong [:edwong]]

can we add this to 43.3 iteration?

Comment 2

[Chris Karlof [:ckarlof]]

Mark, this is something we need to do to land eoger's Bug 1202712 (and not to mention it just generally sucks now). Is this something you or zaach could pick up this iteration?

Comment 3

[Chris Karlof [:ckarlof]]

Assigning to zaach for this iteration. Markh, is it as simple as changing this string?

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsIFaviconService.idl#136

Comment 4

[Chris Karlof [:ckarlof]]

Perhaps with chrome://browser/skin/identity-not-secure.svg

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Karlof [:ckarlof] from comment #3)
> Assigning to zaach for this iteration. Markh, is it as simple as changing
> this string?
> 
> https://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> nsIFaviconService.idl#136

It looks like it probably is. However, I think that should be done in bug 1074937 rather than here - that is older and has more relevant people already CCd (but Zach taking that bug is fine)

> Perhaps with chrome://browser/skin/identity-not-secure.svg

That might be OK, but we'd probably want the file copied so its name is relevant. I think you will want to needinfo shorlander (or ask for uxreview on an attachment) to sign-off on the icon.

Comment 6

[Edwin Wong [:edwong]]

NI'd shorelander on asset in bug 1074937

Comment 7

[Edwin Wong [:edwong]]

we've got a r+ on the asset.

Comment 8

[Edwin Wong [:edwong]]

:markh - should we add this to 44.1

Comment 9

[Edwin Wong [:edwong]]

Mark is going to work on this in bug 1074937