pass --utility-path to b2g mochitests

RESOLVED FIXED in Firefox 43

Status

Testing
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Blocks: 1196430
(Assignee)

Comment 1

3 years ago
Created attachment 8658258 [details] [diff] [review]
pass --utility-path to b2g mochitests

Just like what we discussed over in bug 1196430.  Please let me know if there
are other places I should modify.  I think Mulet tests already include
--utility-path...somehow...so I don't need to care about them here.
Attachment #8658258 - Flags: review?(ahalberstadt)
(Assignee)

Comment 2

3 years ago
Created attachment 8658307 [details] [diff] [review]
pass --utility-path to b2g mochitests

Here, this seems to work much better.  The setting in b2g_emulator_config.py
didn't have any effect, but it seems reasonable to duplicate the change there
for completeness.
Attachment #8658258 - Attachment is obsolete: true
Attachment #8658258 - Flags: review?(ahalberstadt)
Attachment #8658307 - Flags: review?(ahalberstadt)
Comment on attachment 8658307 [details] [diff] [review]
pass --utility-path to b2g mochitests

Review of attachment 8658307 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the other patch modifies the test harness to use this? Might be prudent to do a little try run too if you haven't already, the code that post processes the options is a little hairy. Looks good, r+ with comment below fixed.

::: testing/config/mozharness/b2g_emulator_config.py
@@ +67,5 @@
>                  "--emulator=%(emulator)s",
>                  "--logdir=%(logcat_dir)s",
>                  "--remote-webserver=%(remote_webserver)s",
>                  "--xre-path=%(xre_path)s",
> +                "--utility-path=%(utility_path)s",

This config is only being used by the old out-of-tree mozharness (which is still being used by taskluster based jobs until bug 1188330 gets fixed). So adding this here will break emulator-kk tests on some weird staging branch because they are the only emulator jobs still using this config + out-of-tree mozharness and out-of-tree mozharness doesn't have the other half of this patch.

tl;dr please revert this file, it will be removed soon anyway :)
Attachment #8658307 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/4a6f9f070485
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.