Closed Bug 1202752 Opened 7 years ago Closed 7 years ago

Overlapping utility trays

Categories

(B2GDroid Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsavory, Assigned: sgiles)

References

Details

Attachments

(1 file, 3 obsolete files)

Gesture for android utility tray and FxOS utility tray conflict, making it difficult to target one over the other. Only one utility tray should be accessible to the user.
Assignee: nobody → sgiles
Attached patch overlapping-utility-trays.patch (obsolete) — Splinter Review
This kind of goes with my other patch for Notifications, but, this is a massive hack! :)
Attachment #8681364 - Flags: review?(fabrice)
I tested a bit. This doesn't work 100% of the time (I still manage sometimes to get the android tray) but that makes it easier to get ours for sure.

One bad side effect though is that when you're in an android app, it's also very hard to reach the android tray.
Attached patch overlapping-utility-trays.patch (obsolete) — Splinter Review
I found a solution to the problem you were seeing.  Just hide the hacked overlay when we lose focus :).
Attachment #8681364 - Attachment is obsolete: true
Attachment #8681364 - Flags: review?(fabrice)
Attachment #8682733 - Flags: review?(fabrice)
Attached patch overlapping-utility-trays.patch (obsolete) — Splinter Review
Depends on the patch in bug 1202767
Attachment #8682733 - Attachment is obsolete: true
Attachment #8682733 - Flags: review?(fabrice)
Attachment #8682768 - Flags: review?(fabrice)
Comment on attachment 8682768 [details] [diff] [review]
overlapping-utility-trays.patch

Review of attachment 8682768 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits fixed.

::: mobile/android/b2gdroid/app/src/main/java/org/mozilla/b2gdroid/Launcher.java
@@ +14,5 @@
>  import android.os.Bundle;
>  import android.support.v4.app.FragmentActivity;
>  import android.util.Log;
> +
> +import android.graphics.PixelFormat;

nit: move that line in alphabetical order.

@@ +19,4 @@
>  import android.view.View;
> +import android.view.WindowManager;
> +import android.view.Gravity;
> +import android.view.MotionEvent;

and re-oreder these too.
Attachment #8682768 - Flags: review?(fabrice) → review+
Obsoletes r+d attachment 8682768 [details] [diff] [review] (nits fixed).
Attachment #8682768 - Attachment is obsolete: true
Depends on: 1202767
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3e4883a63feb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.