1202752 - Overlapping utility trays

Status: RESOLVED FIXED

(B2GDroid Graveyard :: General, defect)

Description

[Jacqueline Savory [:jsavory] UX]

Gesture for android utility tray and FxOS utility tray conflict, making it difficult to target one over the other. Only one utility tray should be accessible to the user.

Comment 1

[sgiles]

Attachment: overlapping-utility-trays.patch

This kind of goes with my other patch for Notifications, but, this is a massive hack! :)

Comment 2

[[:fabrice] Fabrice Desré]

I tested a bit. This doesn't work 100% of the time (I still manage sometimes to get the android tray) but that makes it easier to get ours for sure.

One bad side effect though is that when you're in an android app, it's also very hard to reach the android tray.

Comment 3

[sgiles]

Attachment: overlapping-utility-trays.patch

I found a solution to the problem you were seeing.  Just hide the hacked overlay when we lose focus :).

Comment 4

[sgiles]

Attachment: overlapping-utility-trays.patch

Depends on the patch in bug 1202767

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8682768 [details] [diff] [review]
overlapping-utility-trays.patch

Review of attachment 8682768 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits fixed.

::: mobile/android/b2gdroid/app/src/main/java/org/mozilla/b2gdroid/Launcher.java
@@ +14,5 @@
>  import android.os.Bundle;
>  import android.support.v4.app.FragmentActivity;
>  import android.util.Log;
> +
> +import android.graphics.PixelFormat;

nit: move that line in alphabetical order.

@@ +19,4 @@
>  import android.view.View;
> +import android.view.WindowManager;
> +import android.view.Gravity;
> +import android.view.MotionEvent;

and re-oreder these too.

Comment 6

[sgiles]

Attachment: overlapping-utility-trays.patch

Obsoletes r+d attachment 8682768 [details] [diff] [review] (nits fixed).

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3e4883a63feb

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e4883a63feb