1202790 - Android "mach xpcshell-test" without a test path warns "only the first test path argument will be used"

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1160164 +++

This is the same cause as bug 1160164 (['all'] vs 'all), but applies to android, where the behavior is a little different:

$ ./mach xpcshell-test
From _tests: Kept 36291 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.41 LOG: MainThread mozdevice INFO will use zip to push directories
using APK: /home/gbrown/objdirs/droid/dist/fennec-43.0a1.en-US.android-arm.apk
Warning: only the first test path argument will be used.
Pushing xpcshell..
...
 1:21.73 SUITE_START: MainThread 2143
 1:22.27 TEST_START: Thread-1 caps/tests/unit/test_origin.js
 1:22.27 LOG: Thread-1 INFO caps/tests/unit/test_origin.js | full command: ['/data/local/xpcb/xpcw', '-r', '/sdcard/tests/xpcshell/c/httpd.manifest', '--greomni', u'/data/local/xpcb/fennec-43.0a1.en-US.android-arm.apk', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "/sdcard/tests/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "/sdcard/tests/xpcshell/p/mozinfo.json";', '-e', 'const _TESTING_MODULES_DIR = "/sdcard/tests/xpcshell/m";', '-f', '/sdcard/tests/xpcshell/head.js', '-e', 'const _SERVER_ADDR = "localhost"', '-e', 'const _HEAD_FILES = [];', '-e', 'const _TAIL_FILES = [];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', u'const _TEST_FILE = ["test_origin.js"];', '-e', u'const _TEST_NAME = "caps/tests/unit/test_origin.js"', '-e', '_execute_test(); quit(0);']
 1:22.27 LOG: Thread-1 INFO caps/tests/unit/test_origin.js | current directory: u'/sdcard/tests/xpcshell/caps/tests/unit'
 1:22.27 LOG: Thread-1 INFO caps/tests/unit/test_origin.js | environment: {'MOZ_CRASHREPORTER': '1', 'XPCSHELL_TEST_TEMP_DIR': '/sdcard/tests/xpcshell/tmp', 'XPCOM_DEBUG_BREAK': 'stack-and-abort', 'XPCSHELL_MINIDUMP_DIR': '/sdcard/tests/xpcshell/minidumps', 'GRE_HOME': '/data/data/org.mozilla.fennec_gbrown', 'MOZ_DISABLE_NONLOCAL_CONNECTIONS': '1', 'XPCSHELL_TEST_PROFILE_DIR': '/sdcard/tests/xpcshell/p', 'MOZ_CRASHREPORTER_NO_REPORT': '1', 'HOME': '/sdcard/tests/xpcshell/p', 'MOZ_LINKER_CACHE': '/data/local/xpcb', 'LD_LIBRARY_PATH': '/data/local/xpcb', 'TMPDIR': '/sdcard/tests/xpcshell/tmp'}
 1:25.32 PROCESS_OUTPUT: Thread-1 (pid:caps/tests/unit/test_origin.js) Full command: ['/data/local/xpcb/xpcw', u'/sdcard/tests/xpcshell/caps/tests/unit', '-r', '/sdcard/tests/xpcshell/c/httpd.manifest', '--greomni', u'/data/local/xpcb/fennec-43.0a1.en-US.android-arm.apk', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "/sdcard/tests/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "/sdcard/tests/xpcshell/p/mozinfo.json";', '-e', 'const _TESTING_MODULES_DIR = "/sdcard/tests/xpcshell/m";', '-f', '/sdcard/tests/xpcshell/head.js', '-e', 'const _SERVER_ADDR = "localhost"', '-e', 'const _HEAD_FILES = [];', '-e', 'const _TAIL_FILES = [];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', u'const _TEST_FILE = ["test_origin.js"];', '-e', u'const _TEST_NAME = "caps/tests/unit/test_origin.js"', '-e', '_execute_test(); quit(0);']
(pid:caps/tests/unit/test_origin.js) "xpcw: cd /sdcard/tests/xpcshell/caps/tests/unit"
 1:25.32 PROCESS_OUTPUT: Thread-1 (pid:caps/tests/unit/test_origin.js) "xpcw: xpcshell -r /sdcard/tests/xpcshell/c/httpd.manifest --greomni /data/local/xpcb/fennec-43.0a1.en-US.android-arm.apk -m -s -e const _HEAD_JS_PATH = "/sdcard/tests/xpcshell/head.js"; -e const _MOZINFO_JS_PATH = "/sdcard/tests/xpcshell/p/mozinfo.json"; -e const _TESTING_MODULES_DIR = "/sdcard/tests/xpcshell/m"; -f /sdcard/tests/xpcshell/head.js -e const _SERVER_ADDR = "localhost" -e const _HEAD_FILES = []; -e const _TAIL_FILES = []; -e const _JSDEBUGGER_PORT = 0; -e const _TEST_FILE = ["test_origin.js"]; -e const _TEST_NAME = "caps/tests/unit/test_origin.js" -e _execute_test(); quit(0);"
 1:19.79 LOG: Thread-1 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
 1:19.83 TEST_STATUS: Thread-1 run_test PASS [run_test : 39] "[System Principal]" == "[System Principal]"

Note the warning about the "first test argument" and the verbose output.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: test for 'all' instead of ['all']

Output is much cleaner with this patch:

$ ./mach xpcshell-test
From _tests: Kept 36291 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.40 LOG: MainThread mozdevice INFO will use zip to push directories
using APK: /home/gbrown/objdirs/droid/dist/fennec-43.0a1.en-US.android-arm.apk
Pushing xpcshell..
...
 1:12.23 LOG: MainThread INFO Running tests sequentially.
 1:12.23 SUITE_START: MainThread 2143
 1:12.77 TEST_START: Thread-1 caps/tests/unit/test_origin.js
 1:15.52 TEST_END: Thread-1 PASS
 1:16.65 TEST_START: Thread-2 chrome/test/unit/test_abi.js
 1:17.81 TEST_END: Thread-2 PASS
 1:18.88 TEST_START: Thread-3 chrome/test/unit/test_bug292789.js
 1:20.12 TEST_END: Thread-3 PASS
...

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46f3675eec80

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46f3675eec80