120282 - javascript error in metadata.js (Link Properties doesn't work)

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Henrik Gemal]

Right click on a link and select properties. Almost nothing is shown in the
dialog. Could be due to this error in the console:

Error: abbr has no properties
Source File: chrome://navigator/content/metadata.js
Line: 462

build 20020115

Comment 1

[Peter Trudelle]

-> [e-mail]

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 109479 has been marked as a duplicate of this bug. ***

Comment 3

[Warner Young]

*** Bug 125764 has been marked as a duplicate of this bug. ***

Comment 4

[Neil Marshall]

Attachment: Fixes the problem

The problem is that any page that contains a <link> tag and doesn't contain a
lang="" will screw up.	The patch that I've attached causes the
convertLanguageCode function to automatically return if it recieves a language
of "".

Another way of fixing this would be to add a check at the source, but I figured
it would be best to catch all cases as opposed to just this one.  The "" string
is being sent from the checkForLink function.  Right now it doesn't check what
it's sending before it sends it.

Comment 5

[Neil Marshall]

Attachment: Moved it up a line.

Comment 6

[Alec Flett]

Comment on attachment 72663 [details] [diff] [review]
Moved it up a line.

sr=alecf

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 72663 [details] [diff] [review]
Moved it up a line.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 8

[Neil Marshall]

The was checked into the trunk yesterday so it should be fixed.

Comment 9

[Tuukka Tolvanen (sp3000)]

*** Bug 130039 has been marked as a duplicate of this bug. ***

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.03.13 comm bits on linux rh7.2, win2k and mac 10.1.3.