Closed
Bug 1202853
Opened 10 years ago
Closed 10 years ago
Markdown doesn't work when adding a comment attachment
Categories
(Bugzilla :: Attachments & Requests, defect)
Bugzilla
Attachments & Requests
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: altlist, Assigned: altlist)
Details
Attachments
(1 file, 1 obsolete file)
|
825 bytes,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
Markdown doesn't work when adding comment to an attachment. This is because the markdown flag doesn't get sent to Bug::add_comment function.
I've attached a proposed fix.
|
Assignee | |
Updated•10 years ago
|
Attachment #8658374 -
Attachment is patch: true
Attachment #8658374 -
Attachment mime type: text/x-patch → text/plain
Attachment #8658374 -
Flags: review?(dkl)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8658374 [details] [diff] [review]
v1
>+ && $cgi->param('use_markdown') eq '1') ? 1 : 0;
You don't care if $cgi->param('use_markdown') is equal to 1 or not. You only care if this parameter is true. This avoid warnings when this parameter is not defined.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Updated version to address comment #1
Attachment #8658374 -
Attachment is obsolete: true
Attachment #8658374 -
Flags: review?(dkl)
Attachment #8679587 -
Flags: review?(dylan)
|
|
||
Updated•10 years ago
|
Assignee: attach-and-request → altlist
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 6.0
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8679587 [details] [diff] [review]
v2
Review of attachment 8679587 [details] [diff] [review]:
-----------------------------------------------------------------
r=dylan
Good fix
Attachment #8679587 -
Flags: review?(dylan) → review+
|
|
||
Comment 4•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
8f405c0..9f5a8a2 master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•