1202900 - support chrome.runtime.connect in webextensions

Status: RESOLVED INCOMPLETE

(WebExtensions :: Untriaged, defect)

Description

[yan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.85 Safari/537.36

Steps to reproduce:

Install a webextensions add-on that calls chrome.runtime.connect()


Actual results:

Console error: "TypeError: chrome.runtime.connect is not a function"


Expected results:

chrome.runtime.connect() should return a Port object for extension message-passing

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Could you post a sample extension? We do try to support runtime.connect, and we have tests for it. Probably you're using it in a different way than we expect.

Comment 2

[drhen123]

(In reply to Bill McCloskey (:billm) from comment #1)
> Could you post a sample extension? We do try to support runtime.connect, and
> we have tests for it. Probably you're using it in a different way than we
> expect.

I also have come across this problem, I can provide an add-on that uses this if needed.

Comment 3

[Kris Maglione [:kmag]]

(In reply to drhen123 from comment #2)
> (In reply to Bill McCloskey (:billm) from comment #1)
> > Could you post a sample extension? We do try to support runtime.connect, and
> > we have tests for it. Probably you're using it in a different way than we
> > expect.
> 
> I also have come across this problem, I can provide an add-on that uses this
> if needed.

Please do.

Comment 4

[drhen123]

(In reply to Kris Maglione [:kmag] from comment #3)
> (In reply to drhen123 from comment #2)
> > (In reply to Bill McCloskey (:billm) from comment #1)
> > > Could you post a sample extension? We do try to support runtime.connect, and
> > > we have tests for it. Probably you're using it in a different way than we
> > > expect.
> > 
> > I also have come across this problem, I can provide an add-on that uses this
> > if needed.
> 
> Please do.

https://chrome.google.com/webstore/detail/mousehunt-horntracker-for/aoakbimfnggbhoplpfcpeifgbigmpepl?hl=en

This extension uses this in a lot of places, hope it helps happy to answer questions.

Comment 5

[drhen123]

(In reply to drhen123 from comment #4)
> (In reply to Kris Maglione [:kmag] from comment #3)
> > (In reply to drhen123 from comment #2)
> > > (In reply to Bill McCloskey (:billm) from comment #1)
> > > > Could you post a sample extension? We do try to support runtime.connect, and
> > > > we have tests for it. Probably you're using it in a different way than we
> > > > expect.
> > > 
> > > I also have come across this problem, I can provide an add-on that uses this
> > > if needed.
> > 
> > Please do.
> 
> https://chrome.google.com/webstore/detail/mousehunt-horntracker-for/
> aoakbimfnggbhoplpfcpeifgbigmpepl?hl=en
> 
> This extension uses this in a lot of places, hope it helps happy to answer
> questions.

Also if you need the same extension as an xpi file format here you go
https://www.dropbox.com/s/gczxn4ikxao7vu5/borderify.xpi?dl=0

Comment 6

[Kris Maglione [:kmag]]

(In reply to drhen123 from comment #4)
> This extension uses this in a lot of places, hope it helps happy to answer
> questions.

Thanks. Unfortunately, using it in a lot of places is much less helpful than using it in only one. Do you have any examples that show just the code where there's a problem?

Comment 7

[Kris Maglione [:kmag]]

If anyone else can provide a testcase, that would be extremely helpful.

I can't figure out how the add-on in comment 5 is supposed to work, and we have tests that use runtime.connect in the same ways that it does, so I don't know where to start looking into this.

Comment 8

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

Hi reporter,

Can you please provide a link to an add on so I can try to reproduce this issue?

Also, is this still reproducible on your end ? If yes, can you please retest this using latest FF release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E).

Thanks,
Paul.

Comment 9

[:shell escalante]

can't repro