Closed Bug 1202908 Opened 4 years ago Closed 4 years ago

remove CSS_PROPERTY_ALWAYS_ENABLED_IN_CHROME_OR_CERTIFIED_APP

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: dbaron, Assigned: xidorn)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Now that bug 961871 has shipped, I don't think we need CSS_PROPERTY_ALWAYS_ENABLED_IN_CHROME_OR_CERTIFIED_APP anymore.  And given that I'd hope we don't need it again, I think we should remove it.
FWIW, we do have some features only available for certificated apps on Firefox OS, e.g. Bluetooth API, Device Storage API, etc.

But since CSS is mostly for rendering, I guess it shouldn't have too many things like the APIs.
Blocks: 1069192
Assignee: nobody → quanxunzhen
Bug 1202908 part 1 - Remove pref layout.css.will-change.enabled.
Attachment #8659694 - Flags: review?(dbaron)
Bug 1202908 part 2 - Remove CSS_PROPERTY_ALWAYS_ENABLED_IN_CHROME_OR_CERTIFIED_APP.
Attachment #8659695 - Flags: review?(dbaron)
Comment on attachment 8659694 [details]
MozReview Request: Bug 1202908 part 1 - Remove pref layout.css.will-change.enabled.

https://reviewboard.mozilla.org/r/19005/#review16873
Attachment #8659694 - Flags: review?(dbaron) → review+
Comment on attachment 8659695 [details]
MozReview Request: Bug 1202908 part 2 - Remove CSS_PROPERTY_ALWAYS_ENABLED_IN_CHROME_OR_CERTIFIED_APP.

https://reviewboard.mozilla.org/r/19007/#review16875

::: layout/style/nsDOMCSSDeclaration.cpp:438
(Diff revision 1)
> +  MOZ_ASSERT_UNREACHABLE("This is currently not used anywhere, "

Please make a note in bug 1069192 that if you don't end up using this, you should delete this function (and its template variant) as well.
Attachment #8659695 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc0228c2d3d4b0520b3d8b2dbc1c128446bf3c4
Bug 1202908 part 1 - Remove pref layout.css.will-change.enabled. r=dbaron

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc38465a23b9806131730f208afedc669287a73
Bug 1202908 part 2 - Remove CSS_PROPERTY_ALWAYS_ENABLED_IN_CHROME_OR_CERTIFIED_APP. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/6bc0228c2d3d
https://hg.mozilla.org/mozilla-central/rev/9bc38465a23b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
dev-doc-needed to update any mention of layout.css.will-change.enabled on MDN.
Keywords: dev-doc-needed
Edited: layout.css.will-change.enabled  to say that the pref doesn't exist in Fx 43 onwards.
You need to log in before you can comment on or make changes to this bug.