Closed Bug 1202940 Opened 4 years ago Closed 4 years ago

Remove pref layout.css.ruby.enabled

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- affected
firefox45 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

We have been shipping CSS Ruby since Firefox 38, and it is unlikely we would want to turn it off again in the future. Given this, we could remove the pref soon.
Maybe time to do this?
Flags: needinfo?(quanxunzhen)
Bug 1202940 part 1 - Move html.css and ua.css back to be loaded in constructor of nsLayoutStylesheetCache.

DependentPrefChanged and InvalidateSheet are no longer used anywhere, but it is
probably better to keep them as-is, since we may need them again in the future.
Attachment #8693395 - Flags: review?(dbaron)
Bug 1202940 part 2 - Remove layout.css.ruby.enabled pref.
Attachment #8693396 - Flags: review?(dbaron)
Flags: needinfo?(quanxunzhen)
Assignee: nobody → quanxunzhen
Comment on attachment 8693395 [details]
MozReview Request: Bug 1202940 part 1 - Move html.css and ua.css back to be loaded in constructor of nsLayoutStylesheetCache.

https://reviewboard.mozilla.org/r/26439/#review23847
Attachment #8693395 - Flags: review?(dbaron) → review+
Attachment #8693396 - Flags: review?(dbaron) → review+
Comment on attachment 8693396 [details]
MozReview Request: Bug 1202940 part 2 - Remove layout.css.ruby.enabled pref.

https://reviewboard.mozilla.org/r/26441/#review23849

Please also remove the line from modules/libpref/init/all.js that makes the pref exist

r=dbaron with that
https://hg.mozilla.org/integration/mozilla-inbound/rev/facc049f03419f47f32cec8f7c45a5336dc332b6
Bug 1202940 part 1 - Move html.css and ua.css back to be loaded in constructor of nsLayoutStylesheetCache. r=dbaron

https://hg.mozilla.org/integration/mozilla-inbound/rev/17a33fbe0c031193d1ed1ab7b07959a21ac18ce1
Bug 1202940 part 2 - Remove layout.css.ruby.enabled pref. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/facc049f0341
https://hg.mozilla.org/mozilla-central/rev/17a33fbe0c03
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Marking this as documented as there wasn't any mention of the preference.
I removed mention of this from https://developer.mozilla.org/en-US/Firefox/Releases/45 , since I don't think it's interesting to say that we removed an internal pref for a feature that's been enabled for a long time.
You need to log in before you can comment on or make changes to this bug.