Closed Bug 1202945 Opened 8 years ago Closed 7 years ago

[settings] separate openIncompatibleSettingsDialog with DialogService

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: ralin)

References

Details

Attachments

(1 file)

[gaia] raylin:1202945-openIncompatibleSettingsDialog-dialog-service > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review 
we can wrap utils::openIncompatibleSettingsDialog as AMD module and include in only related panels
tracking-b2g: --- → backlog
after diagnose I think we don't need this helper function anymore. We can reuse DialogService and separate openIncompatibleSettingsDialog functions into correspondent modules
Summary: [settings] move openIncompatibleSettingsDialog to AMD module → [settings] separate openIncompatibleSettingsDialog with DialogService
Assignee: nobody → ralin
Comment on attachment 8700541 [details] [review]
[gaia] raylin:1202945-openIncompatibleSettingsDialog-dialog-service > mozilla-b2g:master

Hi,


1. changed IncompatibleSettingsDialog to DialogService in hotspot and usb_storage panels.
2. removed IncompatibleSettingsDialog from settings app. (js and html)


Thanks,
Attachment #8700541 - Flags: review?(gasolin)
Comment on attachment 8700541 [details] [review]
[gaia] raylin:1202945-openIncompatibleSettingsDialog-dialog-service > mozilla-b2g:master

thanks!
Attachment #8700541 - Flags: review?(gasolin) → review+
https://github.com/mozilla-b2g/gaia/commit/47aeb3a63fa95b17c16724c5c6ad85f88689027c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.