1202968 - ui/button should be able to toggle style between dark theme and light theme

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Install an add-on that uses ui/button, like
https://addons.mozilla.org/zh-TW/firefox/addon/dinbendon-reminder/
2. Find a dark lwtheme like
https://addons.mozilla.org/en-US/firefox/addon/summerwood/
3. Observe the button

Expected:

1. The icon should still be visible.

Actual

1. The icon is hard to see.

Problem:

According to [1] there is no way for me to specify a light-colored icon for the button when the user switches to a dark lwtheme. We would need an API change here.

[1] https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_toggle

Alternatively we could try to expose the state of the theme (dark/light) and emit change event accordingly to the SDK world, but I couldn't find that module either.

Comment 1

[Takanori MATSUURA]

This bug lies at rest in the graveyard.