Closed Bug 1202971 Opened 6 years ago Closed 6 years ago

Fix compile warnings in libmar

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(2 files, 2 obsolete files)

(part 1) - Fix compile warnings in libmar
3.85 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review
(part 2) - Fix compile warnings in toolkit/mozapps/update/tests
1.78 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
libmar has a couple of compile warnings with GCC.
Attached patch Fix compile warnings in libmar (obsolete) — — Splinter Review
Attachment #8658515 - Flags: review?(robert.strong.bugs)
Attached patch Fix compile warnings in libmar (obsolete) — — Splinter Review 
Try server showed up one that I didn't get locally.
Attachment #8658526 - Flags: review?(robert.strong.bugs)
Attachment #8658515 - Attachment is obsolete: true
Attachment #8658515 - Flags: review?(robert.strong.bugs)
Also remove ALLOW_COMPILER_WARNINGS=True so they don't come back.
Attachment #8658527 - Flags: review?(robert.strong.bugs)
Attachment #8658526 - Attachment is obsolete: true
Attachment #8658526 - Flags: review?(robert.strong.bugs)
Attachment #8658528 - Flags: review?(robert.strong.bugs) → review+
Attachment #8658527 - Flags: review?(robert.strong.bugs) → review+
You need to log in before you can comment on or make changes to this bug.