[Settings] Convert call settings switches to use web components

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8658517 [details] [review]
[gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8658517 [details] [review]
[gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master

Hi Fred,

Wondering if you could review this. I've verified the following things appear to appear visually correct (had to tinker in WebIDE to get to these states):

Verified the following visuals work ok:
* Voice privacy mode
* Call waiting switch - normal state
* Call waiting switch - unknown state
* Call waiting dialog switch

I'm not sure if there's anything else that needs to be covered. Thanks for the help!
Attachment #8658517 - Flags: review?(gasolin)

Comment 3

3 years ago
Comment on attachment 8658517 [details] [review]
[gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master

Thanks for the patch. I leave sine comment on github. Due to the RTL patch is just landed to settings, there might be some change need to be addressed as well.
Attachment #8658517 - Flags: review?(gasolin)

Comment 4

3 years ago
r/sine/some :p
(Assignee)

Comment 5

3 years ago
Comment on attachment 8658517 [details] [review]
[gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master

Hi Fred,

Comments addressed and rebased against master. Please take a look if you can, thanks!
Attachment #8658517 - Flags: review?(gasolin)

Comment 6

3 years ago
Comment on attachment 8658517 [details] [review]
[gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master

Looks fine except the opacity should be 0.3, or the text color will looks slightly different from the next item (Caller ID) while in waiting.
Attachment #8658517 - Flags: review?(gasolin) → review+
(Assignee)

Comment 7

3 years ago
Thank you for the review! In master: https://github.com/mozilla-b2g/gaia/commit/b6c41238fb0de33af418621967de3eaa08b5099e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

2 years ago
Depends on: 1240222
You need to log in before you can comment on or make changes to this bug.