1202988 - Don't use GetTempPath for flash's mms.cfg hack for low integrity

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Makoto Kato [:m_kato]]

GetTempPath doesn't return AppData\LocalLow\Temp.  So it isn't good for low integrity (sanbox level=2)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1202988 - Don't use GetTempPath for flash's mms.cfg hack for low integrity; r?aklotz

Bug 1202988 - Don't use GetTempPath for flash's mms.cfg hack for low integrity; r?aklotz

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8658575 [details]
MozReview Request: Bug 1202988 - Don't use GetTempPath for flash's mms.cfg hack for low integrity; r?aklotz

https://reviewboard.mozilla.org/r/18661/#review16749

r=me with issue addressed.

::: dom/plugins/ipc/PluginModuleChild.cpp:1983
(Diff revision 1)
> +        if (wcslen(path) + 5 < aLen) {

I don't really like this magic number '5' here. I see that it's for "\\Temp" below. So can you just create a NS_NAMED_LITERAL_STRING for "\\Temp" and then call .Length() on it to return the length, instead of having that 5 in there?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f612dcf8a09

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f612dcf8a09