Closed Bug 1203042 Opened 4 years ago Closed 4 years ago

Port bug 1201224 - stop unifying test package during mac universal builds

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(firefox43 affected)

RESOLVED FIXED
Tracking Status
firefox43 --- affected

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(2 files)

Attached patch patch, v1Splinter Review
No description provided.
Attachment #8658588 - Flags: review?(mkmelin+mozilla)
rs=aleth on IRC
https://hg.mozilla.org/comm-central/rev/a3b397572e37
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8658588 [details] [diff] [review]
patch, v1

Review of attachment 8658588 [details] [diff] [review]:
-----------------------------------------------------------------

You forgot to include this bug's number in the commit comment
Attachment #8658588 - Flags: review?(mkmelin+mozilla) → review+
Thanks for bringing this to our attention Ian. I'm not an expert on our Mac packaging, hopefully Florian has an idea.
Flags: needinfo?(clokep) → needinfo?(florian)
(In reply to Ian Neal from comment #3)
> Does IM also need this fix?

For IM we don't use packaged tests, the tests run on the same build slave as the one that produced the build, so my guess is we don't "need" this fix. But it may make sense to port the change anyway just for the sake of consistency.
Flags: needinfo?(florian)
Attachment #8660320 - Flags: review?(florian) → review+
https://hg.mozilla.org/comm-central/rev/61e9c6a292e67921553aa1268b73e7ed05e567e1
Bug 1203042 - Port "stop unifying test package during mac universal builds": flight.mk changes. rs=bustage-fix a=aleth
You need to log in before you can comment on or make changes to this bug.