The default bug view has changed. See this FAQ.

Port bug 1201224 - stop unifying test package during mac universal builds

RESOLVED FIXED

Status

MailNews Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

Trunk

Firefox Tracking Flags

(firefox43 affected)

Details

Attachments

(2 attachments)

Created attachment 8658588 [details] [diff] [review]
patch, v1
Attachment #8658588 - Flags: review?(mkmelin+mozilla)
rs=aleth on IRC
https://hg.mozilla.org/comm-central/rev/a3b397572e37
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 2

2 years ago
Comment on attachment 8658588 [details] [diff] [review]
patch, v1

Review of attachment 8658588 [details] [diff] [review]:
-----------------------------------------------------------------

You forgot to include this bug's number in the commit comment
Attachment #8658588 - Flags: review?(mkmelin+mozilla) → review+

Comment 3

2 years ago
Does IM also need this fix?
http://mxr.mozilla.org/comm-central/search?string=MOZ_BUILD_PROJECTS&find=im%2F&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=comm-central
Flags: needinfo?(clokep)
Thanks for bringing this to our attention Ian. I'm not an expert on our Mac packaging, hopefully Florian has an idea.
Flags: needinfo?(clokep) → needinfo?(florian)
(In reply to Ian Neal from comment #3)
> Does IM also need this fix?

For IM we don't use packaged tests, the tests run on the same build slave as the one that produced the build, so my guess is we don't "need" this fix. But it may make sense to port the change anyway just for the sake of consistency.
Flags: needinfo?(florian)
Created attachment 8660320 [details] [diff] [review]
im patch, v1
Attachment #8660320 - Flags: review?(florian)
Attachment #8660320 - Flags: review?(florian) → review+

Comment 7

2 years ago
This landed: https://hg.mozilla.org/comm-central/rev/5fac23e95a30

Comment 8

2 years ago
https://hg.mozilla.org/comm-central/rev/61e9c6a292e67921553aa1268b73e7ed05e567e1
Bug 1203042 - Port "stop unifying test package during mac universal builds": flight.mk changes. rs=bustage-fix a=aleth
You need to log in before you can comment on or make changes to this bug.