Closed
Bug 1203042
Opened 10 years ago
Closed 10 years ago
Port bug 1201224 - stop unifying test package during mac universal builds
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(firefox43 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(2 files)
|
998 bytes,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
1.81 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8658588 -
Flags: review?(mkmelin+mozilla)
| Assignee | ||
Comment 1•10 years ago
|
||
rs=aleth on IRC
https://hg.mozilla.org/comm-central/rev/a3b397572e37
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 2•10 years ago
|
||
Comment on attachment 8658588 [details] [diff] [review]
patch, v1
Review of attachment 8658588 [details] [diff] [review]:
-----------------------------------------------------------------
You forgot to include this bug's number in the commit comment
Attachment #8658588 -
Flags: review?(mkmelin+mozilla) → review+
Does IM also need this fix?
http://mxr.mozilla.org/comm-central/search?string=MOZ_BUILD_PROJECTS&find=im%2F&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=comm-central
Flags: needinfo?(clokep)
Comment 4•10 years ago
|
||
Thanks for bringing this to our attention Ian. I'm not an expert on our Mac packaging, hopefully Florian has an idea.
Flags: needinfo?(clokep) → needinfo?(florian)
Comment 5•10 years ago
|
||
(In reply to Ian Neal from comment #3)
> Does IM also need this fix?
For IM we don't use packaged tests, the tests run on the same build slave as the one that produced the build, so my guess is we don't "need" this fix. But it may make sense to port the change anyway just for the sake of consistency.
Flags: needinfo?(florian)
| Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8660320 -
Flags: review?(florian)
Updated•10 years ago
|
Attachment #8660320 -
Flags: review?(florian) → review+
Comment 7•10 years ago
|
||
This landed: https://hg.mozilla.org/comm-central/rev/5fac23e95a30
Comment 8•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/61e9c6a292e67921553aa1268b73e7ed05e567e1
Bug 1203042 - Port "stop unifying test package during mac universal builds": flight.mk changes. rs=bustage-fix a=aleth
You need to log in
before you can comment on or make changes to this bug.
Description
•