Closed Bug 1203112 Opened 8 years ago Closed 8 years ago

Buildapi does greedy matching of slavenames when returning list of recent jobs

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: coop, Assigned: coop)

Details

Attachments

(1 file)

[buildapi] Add greedy request parameter
2.87 KB, patch
Callek
: review+
coop
: checked-in+
Details | Diff | Splinter Review 
I notice this primarily in slave health when I'm trying to dig into the performance of a single spot node.

e.g. When trying to investigate the job history of a node like tst-linux64-spot-209, buildapi also shows me the results for tst-linux64-spot-2090, tst-linux64-spot-2091, etc.

Offending line is here:

https://hg.mozilla.org/build/buildapi/file/7f6483294974/buildapi/model/query.py#l190

I don't know who's actually relying on this behavior, but I'd like to be able to set a flag to disable it.

Patch incoming.
Patch keeps the current greedy behavior as default but adds the ability to disable it.
Assignee: nobody → coop
Status: NEW → ASSIGNED
Attachment #8658718 - Flags: review?(bugspam.Callek)
Attachment #8658718 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8658718 [details] [diff] [review]
[buildapi] Add greedy request parameter

https://hg.mozilla.org/build/buildapi/rev/40920bbd6def
Attachment #8658718 - Flags: checked-in+
Deployed version 0.3.19 in staging and production.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.