Closed
Bug 1203165
Opened 10 years ago
Closed 10 years ago
Remove settings in base.py that are identical to Django defaults
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
We have several settings specified in settings/base.py that are redundant, since they are identical to the Django defaults. Lets just remove them to make base.py less verbose.
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8658820 -
Flags: review?(mdoglio)
Updated•10 years ago
|
Attachment #8658820 -
Flags: review?(mdoglio) → review+
Comment 2•10 years ago
|
||
I like this!
Comment 3•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/ff1a51bc740895e5afe373da98f3ea52404e0301
Bug 1203165 - Remove settings that are identical to the Django defaults
Removes settings that are identical to the Django 1.8 defaults:
https://docs.djangoproject.com/en/1.8/ref/settings/#std:setting-ADMINS
https://docs.djangoproject.com/en/1.8/ref/settings/#std:setting-MANAGERS
https://docs.djangoproject.com/en/1.8/ref/settings/#language-code
https://docs.djangoproject.com/en/1.8/ref/settings/#std:setting-USE_TZ
https://docs.djangoproject.com/en/1.8/ref/settings/#std:setting-STATICFILES_DIRS
https://docs.djangoproject.com/en/1.8/ref/settings/#std:setting-STATICFILES_FINDERS
https://docs.djangoproject.com/en/1.8/ref/settings/#test-runner
| Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•