Closed Bug 1203173 Opened 9 years ago Closed 9 years ago

add tests for analyzer views

Categories

(Input Graveyard :: Code Quality, defect)

Product:
Input Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: p=1 s=input.2015q3)

I've been skipping writing tests for analyzer views since that section of the site is not as important as other sections. However, we're about to do a django 1.8 upgrade and having basic tests on those views would help a lot. This bug covers: 1. going through the analyzer views to see which ones lack tests 2. writing up tests for views lacking tests The tests should be basic. We should answer: 1. does this view render? 2. does the basic functionality of this view work?
I think this is about 2 points of work. Writing tests is not hard. We've got the infrastructure for logging in. Should be pretty straight forward.
Whiteboard: p=2 s=input.2015q3
The following views lack tests: 1. hb_data 2. hb_errorlog 3. hb_surveys and hb_surveys_update (might want to just rewrite these using the new way) 4. addproducts (should be renamed to analytics_addproducts to match other views) 5. spot_translate (should be moved from views.py to analyzer_views.py and needs a test) Also, hb_data, hb_errorlog and hb_surveys should all get moved to fjord/heartbeat/. Grabbing this to work on now.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Pushing off rewriting analyzer views to other bugs. All the hb-related stuff is in PR: https://github.com/mozilla/fjord/pull/675
Closed that PR. I'm going to have one PR with all the stuff in it instead.
A bigger PR with all the things in it: https://github.com/mozilla/fjord/pull/676
I nixed rewriting hb_surveys views--I'll do that another day. Thus resizing this down to a 1 point bug.
Whiteboard: p=2 s=input.2015q3 → p=1 s=input.2015q3
Landed in https://github.com/mozilla/fjord/commit/b5c07c6c3d7706d4d529ae9df07c288a69b1f10e This only affects tests, so there's no need to deploy. Marking this as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.