Let unified autocomplete ride the trains

RESOLVED FIXED in Firefox 43

Status

()

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

unspecified
Firefox 43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

(Whiteboard: [suggestions][fxsearch][unifiedcomplete])

Attachments

(1 attachment)

We're ready to ship search suggestions and unified autocomplete so lets drop the ifdef
(Assignee)

Comment 1

3 years ago
Created attachment 8658825 [details] [diff] [review]
patch

We should probably wait until the accessibility bugs have been in a nightly but this is ready for when we want this.
Attachment #8658825 - Flags: review?(adw)
Comment on attachment 8658825 [details] [diff] [review]
patch

Review of attachment 8658825 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +276,1 @@
>  // Use the new unifiedComplete component

This comment isn't doing much, could probably remove it now if you agree.
Attachment #8658825 - Flags: review?(adw) → review+
Whiteboard: [suggestions][fxsearch] → [suggestions][fxsearch][unifiedcomplete]
https://hg.mozilla.org/mozilla-central/rev/716d75dec805
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

Comment 5

3 years ago
I want to verify the fix, but couldn't understand the bug. Carsten can you help me to understand the bug?
Flags: needinfo?(cbook)
This fix just allowed unified complete to be enabled by default in Firefox 43.
It can be verified by checking that Firefox 43 uses the new autocomplete (the one with pre-selected first entry and search suggestions) by default.
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.