Closed
Bug 1203232
Opened 9 years ago
Closed 9 years ago
IPC and STLport not compatible with -Wshadow
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: rbarnes, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
12.30 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
In Bug 1198572, we added an IPC dependency to nsMixedContentBlocker, which had been building with -Wshadow out of an abundance of caution. That led to carnage on try [1] due to files in /ipc/chromium/base and /build/stlport not being compatible with that flag. These issues are easy to resolve by renaming arguments, so we should just do that. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=0993fc6ceb32
|
Assignee | |
Comment 1•9 years ago
|
||
This patch is a continuation of bug 1200131. It does not fix all -Wshadow warnings in ipc/chromium! It just fixes the warnings in ipc header files that infect other directories (like dom/security or xpcom). Green try build with -Wshadow re-enabled for dom/security with these ipc/chromium fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7775d377e849
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8660569 -
Flags: review?(n.nethercote)
|
||
Updated•9 years ago
|
Attachment #8660569 -
Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/05e1fdf35ee3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•