Closed Bug 1203232 Opened 4 years ago Closed 4 years ago

IPC and STLport not compatible with -Wshadow

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: rbarnes, Assigned: cpeterson)

References

Details

Attachments

(1 file)

In Bug 1198572, we added an IPC dependency to nsMixedContentBlocker, which had been building with -Wshadow out of an abundance of caution.  That led to carnage on try [1] due to files in /ipc/chromium/base and /build/stlport not being compatible with that flag.  These issues are easy to resolve by renaming arguments, so we should just do that.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=0993fc6ceb32
Depends on: 1200131
Blocks: 1203234
This patch is a continuation of bug 1200131. It does not fix all -Wshadow warnings in ipc/chromium! It just fixes the warnings in ipc header files that infect other directories (like dom/security or xpcom).

Green try build with -Wshadow re-enabled for dom/security with these ipc/chromium fixes:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7775d377e849
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8660569 - Flags: review?(n.nethercote)
Attachment #8660569 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/05e1fdf35ee3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1207030
You need to log in before you can comment on or make changes to this bug.