Closed Bug 1203234 Opened 4 years ago Closed 4 years ago

Re-enable -Wshadow in /dom/security

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: rbarnes, Assigned: cpeterson)

References

Details

Attachments

(1 file, 1 obsolete file)

In Bug 1198572, we had to disable -Wshadow in order to be compatible with IPC.  Once the IPC code has been cleaned up, we should re-enable that flag.
Depends on: 1203232
Attached patch Wshadow_dom-security.patch (obsolete) — Splinter Review
Re-enable -Wshadow warnings in /dom/security (after my fix for ipc bug 1203232 lands).

Green try build with -Wshadow re-enabled for dom/security with these ipc/chromium fixes:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7775d377e849
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8660571 - Flags: review?(mozilla)
Blocks: 1187711
I am confused, the name of the bug is 'Re-enable -Wshadow in /dom/security' but the change in the patch is 'security/manager/ssl/moz.build'. Chris, can you please clarify?
Flags: needinfo?(cpeterson)
oops! I attached the wrong patch (a test patch for a different bug). Sorry.

Here is a green try build with the correct patch:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd09848b04e6
Attachment #8660571 - Attachment is obsolete: true
Attachment #8660571 - Flags: review?(mozilla)
Flags: needinfo?(cpeterson)
Attachment #8661116 - Flags: review?(mozilla)
Comment on attachment 8661116 [details] [diff] [review]
Wshadow_dom-security_v2.patch

Review of attachment 8661116 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Chris!
Attachment #8661116 - Flags: review?(mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/212427250df6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.