1203270 - [Music][NGA] Optimize view lifecycle

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

Currently, there is noticeable delay when switching tabs in Music NGA since views that are no longer in the <music-view-stack> are discarded. In order to improve performance, the view lifecycle needs optimized so that views can continue to remain "alive" when off-screen. This means that views need to be made aware of when they are hidden, visible and when they are about to be permanently discarded.

All 5 main "tab" views should continue to live regardless of if they are on-screen or not since the user can switch between them at any time. Additionally, the "player" view should also never be discarded since the user can switch directly to the player view at any time.

However, the "playlist-detail", "artist-detail" and "album-detail" views should remain discardable once they are popped off the view stack. This will both save memory and also solve the problem of invalidating the content when re-showing these views. For example, if I drill down into "Album A", go back and then tap on "Album B", the "album-detail" view will need to be completely re-rendered anyway, so we might as well just discard it completely when popped off the view stack. Another option here would be to allow for a view to be recycled. By recycling these views, we may see a minor performance improvement, but it may also require additional memory.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1203270 > mozilla-b2g:master

Comment 2

[Hema Koka [:hema]]

Jim, 

lets get the reviews in and get this wrapped up this week. adding it to current sprint. 

Thanks
hema

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8660145 [details] [review]
[gaia] justindarc:bug1203270 > mozilla-b2g:master

r=me with review comments addressed.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/19696d5db8e7e078204b15597b9d01c788e5f04f