1203289 - unmark gray the mGlobal fields of PromiseCallback subclasses

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

We're running code in the compartments of these globals without marking them as live to the CC, which might cause problems.

Comment 1

[Andrew McCreight [:mccr8]]

It almost feels like we should do ExposeObjectToActiveJS on any object we call JSAutoCompartment with, though I do worry a little about the perf implications of that.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Well, wouldn't it be just moving unmarking from forgotSkippable to happen possibly at some other point? Things which are doing something in a loop would end up having unmarked objects already.
And IIRC the check whether something gray was inlined (but better to verify).
So, might not be too bad.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: expose promise callback things to JS

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=722d9211224f

I think bc4 is just permaorange on trunk...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8659345 [details] [diff] [review]
expose promise callback things to JS

r=me

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f63ec3ee07ed

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f63ec3ee07ed

Comment 7

[Andrew McCreight [:mccr8]]

Comment on attachment 8659345 [details] [diff] [review]
expose promise callback things to JS

Approval Request Comment
[Feature/regressing bug #]: speculative fix for bug 1182197
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]: this code is run frequently
[Risks and why]: might possibly cause leaks, but this is pretty simple and should be okay as we haven't noticed any yet
[String/UUID change made/needed]: none

Comment 8

[Andrew McCreight [:mccr8]]

Comment on attachment 8659345 [details] [diff] [review]
expose promise callback things to JS

See above. This is beta now.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8659345 [details] [diff] [review]
expose promise callback things to JS

Hopefully fix a crash, taking it.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d52e0d884957