Closed Bug 1203294 Opened 5 years ago Closed 5 years ago

Disable password visibility toggling in the capture doorhanger for 41/42

Categories

(Toolkit :: Password Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox40 --- unaffected
firefox41 - fixed
firefox42 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file)

There are still more follow-ups on this UI so disable this UI with a pref flip for 41.
Bug 1203294 - Disable signon.rememberSignons.visibilityToggle. r=dolske
Attachment #8658920 - Flags: review?(dolske)
Comment on attachment 8658920 [details]
MozReview Request: Bug 1203294 - Disable signon.rememberSignons.visibilityToggle. r=dolske

Approval Request Comment
[Feature/regressing bug #]: Bug 1169702
[User impact if declined]: Users will experience an unpolished password capture visibility toggle. They may be surprised that their password is revealed.
[Describe test coverage new/current, TreeHerder]: Reverting to existing behaviour which has been tested for years.
[Risks and why]: Low risk reverting to previous behaviour.
[String/UUID change made/needed]: None
Attachment #8658920 - Flags: approval-mozilla-beta?
Comment on attachment 8658920 [details]
MozReview Request: Bug 1203294 - Disable signon.rememberSignons.visibilityToggle. r=dolske

Turning the pref off seems like a good idea as it seems we still have a few issues that need to be fixed (linked to bug 1169702) before making this a on-by-default feature.
Attachment #8658920 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
It probably makes more sense to track this 42 on wards instead of 41 at this point.
Attachment #8658920 - Flags: review?(dolske) → review+
Comment on attachment 8658920 [details]
MozReview Request: Bug 1203294 - Disable signon.rememberSignons.visibilityToggle. r=dolske

https://reviewboard.mozilla.org/r/18725/#review16777
https://hg.mozilla.org/releases/mozilla-beta/rev/f3b10e98a1d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-beta/rev/bab3ced35371
Summary: Disable password visibility toggling in the capture doorhanger for 41 → Disable password visibility toggling in the capture doorhanger for 41/42
You need to log in before you can comment on or make changes to this bug.