1203361 - FallibleTArray's move constructor could be implicit

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

FallibleTArray's move constructor is currently explicit:
> explicit FallibleTArray(FallibleTArray<E>&& aOther)

This prevents some uses, e.g. return one from a function.

I don't see any reason not to make it implicit, but I don't have as much experience as others who've written&reviewed it (e.g., in bug 982212).
Also, it would be more consistent with nsTArray's move constructor.

But I think we should keep the nsTArray_Impl-move constructors explicit, to prevent changing their fallibility blindly.

Note: I actually don't have a need for it right now; I almost did but went another way. So it's not urgent for me anyway -- just something that I thought could be useful in the future.

Comment 1

[Simon Giesecke [:sg] [he/him]]

FallibleTArray no longer declares an explicit move constructor after Bug 1620632.