1203395 - [window mode] View Selection Source fails

Status: VERIFIED FIXED

(Toolkit :: View Source, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Similar (but not the same) to bug 1168243, bug 1134585.

This applies to Nightly 43 only, not 42.

Only view source window mode is affected.  Tab mode is safe.
Both e10s on and off are affected.

STR:

1. Go to http://www.htmq.com/html/sample/frame.htm
2. Select text from inner frame
3. Context menu -> View Selection Source

ER:

See the selection source in a window.

AR:

Blank window.

Error:

NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: Tracking to make sure this solved, esp. since tabs are currently off in beta / release for the moment.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

I just tried this in OS X 10.10.4 in the current Nightly and it worked. jryans can you still reproduce the bug?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> I just tried this in OS X 10.10.4 in the current Nightly and it worked.
> jryans can you still reproduce the bug?

I can still reproduce with latest Nightly.  I am on OS X 10.10.5.  Are you sure you used window mode?  You'd need to set "view_source.tab" pref to false first, as tab mode is the default in Nightly.  (I should have said that more explicitly above.)

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Oh you're right, that's exactly why I couldn't reproduce it. I see the problem now.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Actually, this is not specific to frames.  It's just any kind of selection in window mode.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1203395 - Repair view selection source in window mode. r=mconley

Bug 1203395 - Repair view selection source in window mode. r=mconley

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2239c266eab3

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8665719 [details]
MozReview Request: Bug 1203395 - Repair view selection source in window mode. r=mconley

https://reviewboard.mozilla.org/r/20309/#review18333

Looks good, thanks jryans!

::: toolkit/components/viewsource/test/browser/browser_contextmenu.js:45
(Diff revision 1)
> +  debugger;

Leftovers? :)

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://reviewboard.mozilla.org/r/20309/#review18333

> Leftovers? :)

Just making sure you're paying attention... ;)

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6b9b783c3ce

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Fixed a test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d24be43940e

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8665719 [details]
MozReview Request: Bug 1203395 - Repair view selection source in window mode. r=mconley

Bug 1203395 - Repair view selection source in window mode. r=mconley

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5636e295717a

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5636e295717a

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8665719 [details]
MozReview Request: Bug 1203395 - Repair view selection source in window mode. r=mconley

Approval Request Comment
[Feature/regressing bug #]: Broken bug 1134585, which converted some context menu functionality for e10s, but did not test the window case
[User impact if declined]: View source selection in window mode in blank
[Describe test coverage new/current, TreeHerder]: On m-c, additional automated tests added
[Risks and why]: Low, new tests added.
[String/UUID change made/needed]: None

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8665719 [details]
MozReview Request: Bug 1203395 - Repair view selection source in window mode. r=mconley

Comes with new tests; fix for regression. Let's uplift to aurora!

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d6f44c82219b

Comment 19

[Cornel Ionce [:noni] [Hubs QA]]

Reproduced the initial issue on 43.0a1 Nightly (2015-09-09) using the STR from the description on Windows 7 64-bit and Mac OS X 10.10.

Confirming the fix for the same OSs using latest 44 Aurora (20151213004008) and Firefox 43 RC (20151208100201).