Closed Bug 1203407 Opened 4 years ago Closed 4 years ago

B2G Installer should allow offline use

Categories

(Firefox OS Graveyard :: B2gInstaller, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

PR
51 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
We regressed offline use after landing support for online registry of builds.

STR:
 0. Be offline
 1. Open about:b2g-installer
 2. Plugin device

Expected:
 Device serial number is detected and I can select a local blobfree zip file

Actual:
 Device serial number does not show and I cannot pick a local blobfree zip file
Depends on: 1194863
Should we just package devices.json inside the addon? people can still contribute to it and we will get nicer device detection etc, having it fetched seems like a mistake in hindsight
(In reply to Dale Harvey (:daleharvey) from comment #1)
> Should we just package devices.json inside the addon? people can still
> contribute to it and we will get nicer device detection etc, having it
> fetched seems like a mistake in hindsight

I think we should just not block user when we have no network and the XHR fails?
Yup can do that too, we will miss the user friendly device name and it may be nice to at least show the users there are builds available if they were to go online, but those are minor issues. Either way I think it would be an improvement
Attached file PR
Attachment #8660661 - Flags: review?(dale)
(In reply to Dale Harvey (:daleharvey) from comment #3)
> Yup can do that too, we will miss the user friendly device name and it may
> be nice to at least show the users there are builds available if they were
> to go online, but those are minor issues. Either way I think it would be an
> improvement

Added displaying a message to the user. That should be good :)
Comment on attachment 8660661 [details] [review]
PR

This looks good, thanks
Attachment #8660661 - Flags: review?(dale) → review+
https://github.com/mozilla-b2g/b2g-installer/commit/71e0d0ca1d4415b582f0956a43a5c96008739aa4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.