1203446 - PlacesUIUtils.showBookmarkDialog issue

Status: RESOLVED INVALID

(Toolkit :: Places, defect)

Description

[hatdio]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.85 Safari/537.36

Steps to reproduce:

Install addon Bookmarks menu:
https://addons.mozilla.org/en-us/firefox/addon/bookmarks-menu/
This adds a toolbar button; click on it then right click on any bookmark and then click 'Properties'


Actual results:

Popup bookmark properties dialog with empty properties.
The function call is:
--------
PlacesUIUtils.showBookmarkDialog({
                                                'action': "edit",
                                                'type': "bookmark",
                                                'itemId': document.popupNode._id
                                                },  window);
Checked document.popupNode._id and was a number

Also in console these are reported:
--------
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/J ... sm/Promise

Date: Sat Sep 05 2015 10:49:59 GMT+0300 (EEST)
Full Message: TypeError: this._node is undefined
Full Stack: _determineItemInfo@chrome://browser/content/places/bookmarkProperties.js:237:7
BookmarkPropertiesPanel.onDialogLoad<@chrome://browser/content/places/bookmarkProperties.js:268:5
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
onload@chrome://browser/content/places/bookmarkProperties2.xul:1:1
PUIU_showBookmarkDialog@resource:///modules/PlacesUIUtils.jsm:470:5
bookmarksMenuAddon.popupItems/<@chrome://custombutton/content/button.js:148:1


Expected results:

The dialog should have the bookmark properties.
This worked until Firefox 40

Comment 1

[Loic]

It regressed probably after bug 951651 which landed in FF40.

Comment 2

[Marco Bonardo [:mak]]

that API now takes a Places node, not an itemId