Closed Bug 1203454 Opened 4 years ago Closed 4 years ago

Backout partial visual refresh implementation from Fx42

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox41 unaffected, firefox42 verified)

VERIFIED FIXED
mozilla42
Iteration:
43.3 - Sep 21
Tracking Status
firefox41 --- unaffected
firefox42 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(5 files)

The visual refresh work for Loop started in 42 and has almost finished in 43. However it isn't suitable for uplift, so we need to backout the few bugs that did land in 42.
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 1 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659142 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 2 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659143 - Flags: approval-mozilla-aurora?
Attachment #8659143 - Attachment is patch: true
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 3 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659146 - Flags: approval-mozilla-aurora?
Attachment #8659146 - Attachment is patch: true
Attachment #8659143 - Attachment description: Backout part 1 - bug 1183618 → Backout part 2 - bug 1183618
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 4 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659148 - Flags: approval-mozilla-aurora?
Attachment #8659148 - Attachment is patch: true
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 5 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659150 - Flags: approval-mozilla-aurora?
Attachment #8659142 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8659143 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8659146 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8659148 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8659150 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thanks for creating this new bug, this is appreciated!
Target Milestone: --- → mozilla42
QA Contact: bogdan.maris
Verified that all the patches were backed out of Firefox 42 beta 2 build 1 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit) and did not found any new issues.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.