Closed
Bug 120347
Opened 23 years ago
Closed 22 years ago
Hitting the delete key should delete entry
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: gullc, Assigned: colinp)
References
Details
Attachments
(1 file)
1.54 KB,
patch
|
Details | Diff | Splinter Review |
The following situation: You have an entry selected in the entry tab. You want to delete it. It would be nice if you could delete it by hitting the delete key OR the delete button on top of the events tab.
Comment 1•23 years ago
|
||
Colin: Can you do this?
Assignee: mikep → colinp
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•22 years ago
|
||
Setting all/all
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Comment 3•22 years ago
|
||
Note that this will work with both key events 8 & 46 (backspace & delete)
Assignee | ||
Comment 4•22 years ago
|
||
mike, please review the patch
Comment 5•22 years ago
|
||
Are the keycodes the same under Windows and Linux? Is that the proper way to do it? I thought you put an access key attribute on the element? We should look into this at XulPlanet.
Assignee | ||
Comment 6•22 years ago
|
||
Yeah, the keycodes are the standard ascii codeset (uniform everywhere), this technique is used throughout the mozilla product in fact. That's what I spent all afternoon looking for.. was how to do this. :) The accesskey is used as a shortcut to access a commonly used operation (like ctrl-r for reload). It's not typically used to access elements in a tree. (That's what onkeypress up and down are for).
Comment 7•22 years ago
|
||
Then it looks good to me... Have you tested it out? If so, check it in.
Assignee | ||
Comment 8•22 years ago
|
||
Ok, will be done tommorrow. Also tommorrow I'm going to do a bunch of work on the UI. There's alot of cleanup to be done to pretify it. :)
Assignee | ||
Comment 9•22 years ago
|
||
Fixed in CVS. Next XPI late today.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•22 years ago
|
||
OK, thanks a lot for fixing it. However, I have an additional request: If I select an event on the Month view (or week/day view) and hit the delete key, nothing happens. I have to change the input focus to the window on the left side, then select the event again, and hit delete to delete it. It would be nice if I could hit the delete key also when I have selected an event on the right part of the window.
Severity: normal → minor
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 11•22 years ago
|
||
Fixed in CVS. This is now being called properly, with <keysets> and everything. The next XPI should be done today or tomorrow.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Comment 13•18 years ago
|
||
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: colint → sunbird
You need to log in
before you can comment on or make changes to this bug.
Description
•