Rejecting an update of an already approved add-ons should not set the add-on status to 'Incomplete'

VERIFIED FIXED

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
--
critical
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: TheOne, Assigned: TheOne)

Tracking

Details

(Assignee)

Description

2 years ago
It seems that rejecting a preliminary review pending version for an add-on that has already preliminary approved versions sets the add-on status to 'Incomplete'.

This completely disables the add-on.

Instead the add-on status should be "Preliminary reviewed".

STR:
1. Upload a new listed add-on, request preliminary review.
2. Grant preliminary review.
3. Upload a new version for that add-on.
4. Reject that version.

Expected results:
Add-on status should be "Preliminary reviewed".

Actual results:
Add-on status is "Incomplete".

Comment 1

2 years ago
Same issue is reproducing if you request a full review, grant it then upload a new versions and reject it.

Updated

2 years ago
Summary: Rejecting an update of an already preliminary reviewed add-ons should not set the add-on status to 'Incomplete' → Rejecting an update of an already approved add-ons should not set the add-on status to 'Incomplete'
(Assignee)

Updated

2 years ago
Assignee: nobody → awagner
Reverted the commits from bug 1197261, added one commit to "re-apply" some fixes done for bug 1199234

PR: https://github.com/mozilla/olympia/pull/731
Fixed in https://github.com/mozilla/olympia/commit/37799e5523a29d67c3a4b36e4e3fb47d4181b929
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
Verified as fixed in FF40(Win7) in addons.allizom.org
Issue is no longer reproducing. After rejecting a new version the add-on keeps the older status.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.